Skip to content

Commit 3018416

Browse files
author
zhixin.lm
committed
输出一些无用的url注释
1 parent be3bc5c commit 3018416

File tree

7 files changed

+15
-37
lines changed

7 files changed

+15
-37
lines changed

src/lib/number/ob_number_format_models.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
#include "lib/number/ob_number_v2.h"
1818
#include "common/ob_object.h"
1919

20-
//see oracle doc Number Format Models: https://docs.oracle.com/cd/B19306_01/server.102/b14200/sql_elements004.htm
2120
#define MAX_FMT_STR_LEN 64
2221

2322
namespace oceanbase

src/lib/utility/ob_fast_convert.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -189,7 +189,6 @@ class ObFastFormatInt
189189
int64_t len_;
190190
};
191191

192-
//ref: https://github.com/jsteemann/atoi
193192
template<typename T>
194193
class ObFastAtoi
195194
{

src/lib/utility/ob_tracepoint.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,6 @@ bool &get_tp_switch()
3535
EventItem &item = ::oceanbase::common::EventTable::instance().get_event(event_no); \
3636
item.call(SELECT(1, ##__VA_ARGS__)); })
3737

38-
// doc: https://yuque.antfin-inc.com/ob/sql/ssc2x0
39-
4038
// to check if a certain tracepoint is set
4139
// example: if (E(50) OB_SUCCESS) {...}
4240
// you can also specify condition:
@@ -240,4 +238,4 @@ class EventTable
240238
}
241239
}
242240

243-
#endif //OCEANBASE_LIB_UTILITY_OB_TRACEPOINT_
241+
#endif //OCEANBASE_LIB_UTILITY_OB_TRACEPOINT_

src/obproxy/cmd/ob_show_create_table_handler.cpp

Lines changed: 11 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
1-
// Copyright 2014-2016 Alibaba Inc. All Rights Reserved.
2-
// Author:
3-
// luoxiaohu.lxh <luoxiaohu.lxh@oceanbase.com>
4-
// Normalizer:
5-
// luoxiaohu.lxh <luoxiaohu.lxh@oceanbase.com>
6-
//
1+
/**
2+
* Copyright (c) 2021 OceanBase
3+
* OceanBase Database Proxy(ODP) is licensed under Mulan PubL v2.
4+
* You can use this software according to the terms and conditions of the Mulan PubL v2.
5+
* You may obtain a copy of Mulan PubL v2 at:
6+
* http://license.coscl.org.cn/MulanPubL-2.0
7+
* THIS SOFTWARE IS PROVIDED ON AN "AS IS" BASIS, WITHOUT WARRANTIES OF ANY KIND,
8+
* EITHER EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO NON-INFRINGEMENT,
9+
* MERCHANTABILITY OR FIT FOR A PARTICULAR PURPOSE.
10+
* See the Mulan PubL v2 for more details.
11+
*/
712

813

914
#define USING_LOG_PREFIX PROXY_CMD

src/obproxy/obutils/ob_config_server_processor.cpp

Lines changed: 0 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -558,13 +558,6 @@ int ObConfigServerProcessor::get_idc_url(const char *rs_url_buf, const int64_t r
558558
K(idc_url_buf_len), K(ret));
559559
} else {
560560
const char *pos = strcasestr(rs_url_buf, RS_URL_KEY_STRING);
561-
/*
562-
* rs url
563-
* http://x.x.x.x:xxxx/services?Action=ObRootServiceInfo&User_ID=xxx&UID=xxx&ObRegion=xxx
564-
*
565-
* idc url
566-
* http://x.x.x.x:xxxx/services?Action=ObIDCRegionInfo&User_ID=xxx&UID=xxx&ObRegion=xxx
567-
* */
568561
if (NULL != pos) {
569562
const int64_t url_head_len = static_cast<int64_t>(pos - rs_url_buf);
570563
const int64_t url_key_len = static_cast<int64_t>(strlen(RS_URL_KEY_STRING));
@@ -576,13 +569,6 @@ int ObConfigServerProcessor::get_idc_url(const char *rs_url_buf, const int64_t r
576569
url_tailer_len);
577570
idc_url_buf[url_head_len + IDC_URL_KEY_STRING.length() + url_tailer_len] = '\0';
578571
} else {
579-
/*
580-
* rs url
581-
* http://x.x.x.x:xxxx/oceanbase_obconfig/${cluster_name}
582-
*
583-
* idc url
584-
* http://x.x.x.x:xxxx/oceanbase_obconfig/${cluster_name}
585-
* */
586572
MEMCPY(idc_url_buf, rs_url_buf, rs_url_buf_len);
587573
MEMCPY(idc_url_buf + rs_url_buf_len,
588574
IDC_URL_TAILER_STRING.ptr(),
@@ -2218,10 +2204,6 @@ int ObConfigServerProcessor::concat_cluster_name_array(char *data, const char *c
22182204
ret = OB_INVALID_ARGUMENT;
22192205
LOG_WDIAG("NULL pointer, invalid curl or url", K(ret));
22202206
} else {
2221-
/* 批量逻辑租户接口:
2222-
curl --location --request GET 'http://127.0.0.1:8000/services?User_ID=alibaba&UID=HNBC&Action=LdgInstanceInfoBatchQuery' --header 'Content-Type: application/json' --data '{
2223-
"LdgClusters": "cluster1,cluster2"}'
2224-
*/
22252207
char tail[] = "\"}";
22262208
int64_t len_data = strlen(data);
22272209
int64_t len_cluster_name = strlen(cluster_name_array);

src/obproxy/proxy/mysql/ob_mysql_sm.cpp

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4045,8 +4045,6 @@ uint8_t ObMysqlSM::get_compressed_or_ob20_request_seq()
40454045
{
40464046
uint8_t seq = 0;
40474047
ObProxyProtocol server_protocol = get_server_session_protocol();
4048-
// compressed pkt seq use the mysql pkt seq
4049-
// if you're confused about this, please check the doc <https://yuque.antfin-inc.com/ob/odp/myfg2mlwo9qiifg7>
40504048
if (ObProxyProtocol::PROTOCOL_CHECKSUM == server_protocol) {
40514049
// load content of file's response use compressed seq
40524050
if (OB_MYSQL_COM_LOAD_DATA_TRANSFER_CONTENT == trans_state_.trans_info_.sql_cmd_) {
@@ -9838,8 +9836,6 @@ bool ObMysqlSM::need_close_last_used_ss()
98389836
common::ObAddr current_addr;
98399837
(void)current_addr.set_sockaddr(trans_state_.server_info_.addr_.sa_);
98409838
const bool is_current_route_readonly_zone = client_session_->dummy_ldc_.is_readonly_zone(current_addr);
9841-
// 当有只读zone存在时,我们期望弱读走只读zone,如果路由策略选择了只读zone,关闭readwrite zone的
9842-
// 连接,节约连接资源,参考问题 https://aone.alibaba-inc.com/code/D579173
98439839
if (is_last_route_readonly_zone != is_current_route_readonly_zone) {
98449840
bret = true;
98459841
LOG_INFO("last used server session not match readwrite policy, need close it", K_(sm_id),
@@ -10198,7 +10194,6 @@ void ObMysqlSM::get_monitor_error_info(int32_t &error_code, ObString &error_msg,
1019810194
{
1019910195
const char *msg = NULL;
1020010196

10201-
//错误设计文档: https://yuque.antfin-inc.com/mesh/tech-risk/pr9ggf#DmHdS
1020210197
if (ObMysqlTransact::TRANSACTION_COMPLETE == trans_state_.current_.state_ || ObMysqlTransact::CMD_COMPLETE == trans_state_.current_.state_) {
1020310198
ObRespAnalyzeResult &resp = trans_state_.trans_info_.server_response_.get_analyze_result();
1020410199
if (trans_state_.inner_errcode_ != 0) {

src/obproxy/proxy/mysqllib/ob_protocol_diagnosis.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,8 @@ class ObMysqlPacketMetaAnalyzer;
8686
class ObRespResult;
8787
enum ObPacketFoldType {
8888
OB_PACKET_FOLD_TYPE_NONE,
89-
OB_PACKET_FOLD_TYPE_ROW, // https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_query_response_text_resultset_row.html
90-
OB_PACKET_FOLD_TYPE_COL_DEF, // https://dev.mysql.com/doc/dev/mysql-server/latest/page_protocol_com_query_response_text_resultset_column_definition.html
89+
OB_PACKET_FOLD_TYPE_ROW,
90+
OB_PACKET_FOLD_TYPE_COL_DEF,
9191
};
9292
enum ObPacketRecordType {
9393
OB_PACKET_RECORD_TYPE_MYSQL = 0,
@@ -237,4 +237,4 @@ class ObProtocolDiagnosis : public ObSharedRefCount
237237
} // end of obproxy
238238
} // end of oceanbase
239239

240-
#endif
240+
#endif

0 commit comments

Comments
 (0)