Skip to content

Conversation

@hhugo
Copy link
Member

@hhugo hhugo commented Jan 18, 2022

Using deoptigate to check performances/optimizations

probably blocked by #1045

@hhugo hhugo marked this pull request as draft January 13, 2023 13:55
@hhugo hhugo force-pushed the refactor-mlbytes branch from 13b9ae1 to 88ff06d Compare April 13, 2024 20:04
@hhugo hhugo changed the title WIP: Runtime: use monomorphic representation for MlBytes Runtime: use monomorphic representation for MlBytes Oct 11, 2024
@hhugo hhugo marked this pull request as ready for review October 11, 2024 08:15
@hhugo
Copy link
Member Author

hhugo commented Oct 14, 2024

If we make Bytes.unsafe_of_string O(n), we would need to fix String.sub, String.get_intN_*, String.get_uintN_*, String.get_utf_*, String.is_valid_utf_*. They convert the whole string argument to bytes but only look at a small subset.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

runtime/js/mlBytes.js:223

  • The bitwise OR operation with 0 is unnecessary and can be removed.
return s.a[i] | 0;

@hhugo hhugo force-pushed the refactor-mlbytes branch 2 times, most recently from e6b9daa to 9a9c22e Compare March 27, 2025 08:23
@hhugo hhugo force-pushed the refactor-mlbytes branch 2 times, most recently from 91073df to e4441d8 Compare May 14, 2025 14:25
@hhugo hhugo force-pushed the refactor-mlbytes branch from e4441d8 to 91063e0 Compare May 21, 2025 11:10
@hhugo hhugo force-pushed the refactor-mlbytes branch from 91063e0 to 2050e43 Compare June 12, 2025 21:05
@hhugo hhugo marked this pull request as draft June 19, 2025 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants