Unit tests for PhpcsDiff and ViolationsMapper. Add ext-gettext to composer, as it is used

Author: TotalWipeOut

composer.json

@@ -4,6 +4,7 @@
     "require": {
         "php": "^7.3 || ^8.0",
         "ext-json": "*",
+        "ext-gettext": "*",
         "squizlabs/php_codesniffer": "*",
         "league/climate": "^3.4"
     },

tests/Mapper/PhpcsViolationsMapperTest.php

@@ -8,6 +8,44 @@
 
 class PhpcsViolationsMapperTest extends TestBase
 {
+    private $mappedData1 = [
+        'file.php' => [
+            'messages' => [
+                [
+                    'line' => 100,
+                    'message' => 'This is the message',
+                    'type' => 'ERROR',
+                ]
+            ],
+        ],
+    ];
+
+    private $mappedData2 = [
+        'SomeImportantClass.php' => [
+            'messages' => [
+                [
+                    'line' => 230,
+                    'message' => 'This is the message',
+                    'type' => 'ERROR',
+                ],
+            ],
+        ],
+        'index.php' => [
+            'messages' => [
+                [
+                    'line' => 230,
+                    'message' => 'This is the message',
+                    'type' => 'ERROR',
+                ],
+                [
+                    'line' => 250,
+                    'message' => 'Some other warning',
+                    'type' => 'WARNING',
+                ]
+            ],
+        ],
+    ];
+
     /**
      * @covers \PhpcsDiff\Mapper\PhpcsViolationsMapper::__construct
      */
@@ -28,4 +66,60 @@ public function testEmptyMapper(): void
 
         $this->assertEmpty($mappedData);
     }
+
+    /**
+     * @covers \PhpcsDiff\Mapper\PhpcsViolationsMapper::__construct
+     * @covers \PhpcsDiff\Mapper\PhpcsViolationsMapper::map
+     */
+    public function testMapperLineMatch(): void
+    {
+        $changedLinesPerFile = [
+            'file.php' => [
+                100,
+            ]
+        ];
+
+        $mappedData = (new PhpcsViolationsMapper($changedLinesPerFile, ''))->map($this->mappedData1);
+
+        self::assertIsArray($mappedData);
+        self::assertCount(1, $mappedData);
+        self::assertIsString($mappedData[0]);
+        self::assertSame($mappedData[0], 'file.php' . PHP_EOL . ' - Line 100 (ERROR) This is the message' . PHP_EOL);
+    }
+
+    /**
+     * @covers \PhpcsDiff\Mapper\PhpcsViolationsMapper::__construct
+     * @covers \PhpcsDiff\Mapper\PhpcsViolationsMapper::map
+     */
+    public function testMapperNoLineMatch(): void
+    {
+        $changedLinesPerFile = [
+            'file.php' => [
+                101,
+            ]
+        ];
+
+        $mappedData = (new PhpcsViolationsMapper($changedLinesPerFile, ''))->map($this->mappedData1);
+
+        self::assertIsArray($mappedData);
+        self::assertCount(0, $mappedData);
+    }
+
+    /**
+     * @covers \PhpcsDiff\Mapper\PhpcsViolationsMapper::__construct
+     * @covers \PhpcsDiff\Mapper\PhpcsViolationsMapper::map
+     */
+    public function testMapperNoFileMatch(): void
+    {
+        $changedLinesPerFile = [
+            'NonMatchedClass.php' => [
+                101,
+            ]
+        ];
+
+        $mappedData = (new PhpcsViolationsMapper($changedLinesPerFile, ''))->map($this->mappedData2);
+
+        self::assertIsArray($mappedData);
+        self::assertCount(0, $mappedData);
+    }
 }

tests/PhpcsDiffTest.php

@@ -0,0 +1,71 @@
+<?php
+
+namespace PhpcsDiff\Tests;
+
+use League\CLImate\CLImate;
+use PhpcsDiff\PhpcsDiff;
+use PHPUnit\Framework\TestCase;
+
+class PhpcsDiffTest extends TestCase
+{
+    /**
+     * @var CLImate
+     */
+    private $cliMate;
+
+    protected function setUp(): void
+    {
+        $this->cliMate = $this->createMock(CLImate::class);
+    }
+
+    /**
+     * @covers \PhpcsDiff\PhpcsDiff::__construct
+     * @covers \PhpcsDiff\PhpcsDiff::error
+     * @covers \PhpcsDiff\PhpcsDiff::getExitCode
+     * @covers \PhpcsDiff\PhpcsDiff::isFlagSet
+     * @covers \PhpcsDiff\PhpcsDiff::setExitCode
+     */
+    public function testExitCodeBeforeRun()
+    {
+        $phpcsDiff = new PhpcsDiff([], $this->cliMate);
+
+        self::assertSame(1, $phpcsDiff->getExitCode());
+    }
+
+    /**
+     * @covers \PhpcsDiff\PhpcsDiff::__construct
+     * @covers \PhpcsDiff\PhpcsDiff::error
+     * @covers \PhpcsDiff\PhpcsDiff::getExitCode
+     * @covers \PhpcsDiff\PhpcsDiff::isFlagSet
+     * @covers \PhpcsDiff\PhpcsDiff::setExitCode
+     */
+    public function testPhpcsDiffNoCurrent()
+    {
+        $phpcsDiff = new PhpcsDiff(['fakeBranch'], $this->cliMate);
+
+        self::assertSame(1, $phpcsDiff->getExitCode());
+    }
+
+    /**
+     * @covers \PhpcsDiff\PhpcsDiff::__construct
+     * @covers \PhpcsDiff\PhpcsDiff::error
+     * @covers \PhpcsDiff\PhpcsDiff::getExitCode
+     * @covers \PhpcsDiff\PhpcsDiff::isFlagSet
+     * @covers \PhpcsDiff\PhpcsDiff::setExitCode
+     */
+    public function testVerboseNoCurrent()
+    {
+        $this->cliMate
+            ->expects(self::exactly(2))
+            ->method('__call')
+            ->withConsecutive(
+                ['comment', ['Running in verbose mode.']],
+                ['error', ['Please provide a <bold>base branch</bold> as the first argument.']]
+            );
+        ;
+
+        $phpcsDiff = new PhpcsDiff(['-v', 'fakeBranch'], $this->cliMate);
+
+        self::assertSame(1, $phpcsDiff->getExitCode());
+    }
+}