From aab9d6d64dc81e0d42a776089669c70b606ac780 Mon Sep 17 00:00:00 2001 From: Dee Evans Date: Sat, 3 Feb 2018 23:25:48 -0700 Subject: [PATCH 1/2] Fixing ActiveRecord::Migration is not supported error in Rails 5 `StandardError: Directly inheriting from ActiveRecord::Migration is not supported. Please specify the Rails release the migration was written for:` Also changed the migration format to the new `def change` --- lib/generators/templates/has_permalink_migration.rb.erb | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/lib/generators/templates/has_permalink_migration.rb.erb b/lib/generators/templates/has_permalink_migration.rb.erb index 94710fc..eb16602 100644 --- a/lib/generators/templates/has_permalink_migration.rb.erb +++ b/lib/generators/templates/has_permalink_migration.rb.erb @@ -1,9 +1,6 @@ -class <%= migration_class_name %> < ActiveRecord::Migration - def self.up +class <%= migration_class_name %> < ActiveRecord::Migration[<%= Rails.version.first(3) %>] + def change add_column :<%= name.underscore.camelize.tableize %>, :permalink, :string add_index :<%= name.underscore.camelize.tableize %>, :permalink end - def self.down - remove_column :<%= name.underscore.camelize.tableize %>, :permalink - end -end \ No newline at end of file +end From d9e3f6212c2e671178416685420a264f66955996 Mon Sep 17 00:00:00 2001 From: Dee Evans Date: Tue, 18 Jun 2019 10:38:58 -0600 Subject: [PATCH 2/2] rails 5 activerecord support --- has_permalink.gemspec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/has_permalink.gemspec b/has_permalink.gemspec index 7b0e68c..62957cc 100644 --- a/has_permalink.gemspec +++ b/has_permalink.gemspec @@ -8,7 +8,7 @@ Gem::Specification.new do |gem| gem.homepage = 'http://haspermalink.org' gem.licenses = ['MIT'] gem.required_ruby_version = '>= 2.0' - gem.add_runtime_dependency 'activerecord', '~> 4.0', '>= 2.0.0' + gem.add_runtime_dependency 'activerecord', '>= 2.0.0' gem.add_development_dependency 'simplecov', '~> 0.11', '>= 0.11.2' gem.add_development_dependency 'coveralls', '~> 0.8.13', '>= 0.8.13' gem.add_development_dependency 'sqlite3', '~> 1.0'