Update username regex pattern in routes #2566
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KipSigei
force-pushed
the
update-django-admin-username-validation
branch
2 times, most recently
from
ba34cb2 to
88f05fc
Compare
Signed-off-by: Kipchirchir Sigei <arapgodsmack@gmail.com>
KipSigei
force-pushed
the
update-django-admin-username-validation
branch
from
02eecba to
37f4237
Compare
KipSigei
force-pushed
the
update-django-admin-username-validation
branch
from
37f4237 to
7d8bee7
Compare
FrankApiyo
previously approved these changes
Mar 8, 2024
Signed-off-by: Kipchirchir Sigei <arapgodsmack@gmail.com>
KipSigei
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes / Features implemented
(?P<username>\w+)only allowed alphanumeric characters and underscores, the new pattern(?P<username>[^/]+)permits any characters except forward slashesSteps taken to verify this change does what is intended
Side effects of implementing this change
Before submitting this PR for review, please make sure you have:
Closes #