Gitweb links broken

[pvinas-novetta]

In the Build Summary tab, the gitweb links to the commits are broken - it is generating links like "https://gerrit1:8443/gitweb/?p=devrepo/repo.git;a=commit; h=7e384362c24d121e0c9ba20e8b48cc6006e8c13b" (notice the extraneous slash between gitweb and ?p). I've verified that I didn't do something silly like add a trailing slash in the gitweb URL in the plan config. Is anyone else seeing this issue? This is with Bamboo 5.7.2 and gReview 1.4.4.1

[onepremise]

Hi @patrickvinas,

Looking into the issue. What happens if you manually copy and paste the url in the browser? does it resolve? I see the same format in our URLs. However, the link resolves and shows the changes in gitweb. Ex:

https://gitweb.mysite.com/?p=arch;a=blob;f=src/java/com/mysite/test/features/stuff/ui/dialog/mysite.java;hb=8d5b365cea5099a7e5862bd8783edf34b1068346

If I remove the slash, chrome will add it back when i enter the selected url without it. Are you proxying through apache? Judging by the port, you're running directly from tomcat? Could it possible be a context path/docbase setting in your server.xml?

[pvinas-novetta]

If I copy and paste into the browser, it gives a 404 error. The commit
message only loads if I remove the slash between the page name (gitweb) and the
query string (?p=...) . We're not using a proxy currently, running directly from the
in-built gerrit webserver (not tomcat, so no server.xml).

In your example the query string starts immediately after the hostname and so requires a slash. Our path includes a page name before the query string, which, if I recall correctly, would not require a slash (or perhaps explicitly requires there to not be a slash).

[scholarsmate]

I'm seeing the same exact issue. I tried removing gitweb suffix from the URL and putting it as the Repository Path, but that didn't do anything that I can see.

[onepremise]

Hi scholarsmate, does the same URL work in the browser? What is the difference between the URL that works in the browser and the link provided from Bamboo?

[vrtareg]

I don't think that it is necessary to have / before query string.
It should work without the traling slash too.
Some of the versions of gitweb does not like that some just ignoring and removing ...