chore: switch to using ktor

Author: aanorbel

composeApp/build.gradle.kts

@@ -99,6 +99,7 @@ kotlin {
         iosMain.dependencies {
             implementation(libs.sqldelight.native)
             implementation(libs.bundles.mobile)
+            implementation(libs.bundles.ios)
         }
         val desktopMain by getting {
             dependencies {

composeApp/src/androidMain/kotlin/org/ooni/probe/net/Http.android.kt

@@ -17,7 +17,6 @@ import org.ooni.engine.Engine
 import org.ooni.engine.NetworkTypeFinder
 import org.ooni.engine.OonimkallBridge
 import org.ooni.engine.TaskEventMapper
-import org.ooni.probe.net.httpGetBytes
 import org.ooni.probe.Database
 import org.ooni.probe.background.RunBackgroundTask
 import org.ooni.probe.config.BatteryOptimization
@@ -210,7 +209,6 @@ class Dependencies(
     private val downloader by lazy {
         DownloadFile(
             fileSystem = FileSystem.SYSTEM,
-            fetchBytes = ::httpGetBytes,
         )
     }
 

composeApp/src/commonMain/kotlin/org/ooni/probe/di/Dependencies.kt

@@ -1,11 +1,17 @@
 package org.ooni.probe.domain
 
+import io.ktor.client.HttpClient
+import io.ktor.client.request.get
+import io.ktor.client.statement.bodyAsBytes
+import io.ktor.http.isSuccess
 import okio.FileSystem
 import okio.Path
 import okio.Path.Companion.toPath
 import okio.buffer
 import okio.use
+import org.ooni.engine.models.Failure
 import org.ooni.engine.models.Result
+import org.ooni.engine.models.Success
 import org.ooni.probe.data.models.GetBytesException
 
 /**
@@ -15,7 +21,6 @@ import org.ooni.probe.data.models.GetBytesException
  */
 class DownloadFile(
     private val fileSystem: FileSystem,
-    private val fetchBytes: suspend (url: String) -> Result<ByteArray, GetBytesException>,
 ) {
     suspend operator fun invoke(
         url: String,
@@ -30,4 +35,32 @@ class DownloadFile(
             target
         }
     }
+
+
+    /**
+     * Perform a simple HTTP GET and return the raw response body bytes.
+     * Uses Ktor HttpClient for cross-platform HTTP operations.
+     */
+    suspend fun fetchBytes(url: String): Result<ByteArray, GetBytesException> {
+         val client: HttpClient = HttpClient()
+
+        return try {
+            val response = client.get(url)
+            val bytes = response.bodyAsBytes()
+
+            if (response.status.isSuccess()) {
+                Success(bytes)
+            } else {
+                Failure(
+                    GetBytesException(
+                        Exception("HTTP ${response.status.value} while GET $url: ${bytes.decodeToString()}")
+                    )
+                )
+            }
+        } catch (e: Throwable) {
+            Failure(GetBytesException(e))
+        } finally {
+            client.close()
+        }
+    }
 }

composeApp/src/commonMain/kotlin/org/ooni/probe/domain/DownloadFile.kt

@@ -30,13 +30,31 @@ class FetchGeoIpDbUpdates(
         private const val GEOIP_DB_REPO: String = "aanorbel/oomplt-mmdb"
     }
 
-    suspend operator fun invoke(): Result<Path?, MkException> =
-        getLatestEngineVersion()
+    suspend operator fun invoke(): Result<Path?, MkException> {
+        // Check if we've already checked today
+        val lastCheckMillis = preferencesRepository.getValueByKey(SettingsKey.MMDB_LAST_CHECK).first() as? Long
+        if (lastCheckMillis != null) {
+            val currentTimeMillis = Clock.System.now().toEpochMilliseconds()
+            val oneDayInMillis = 24 * 60 * 60 * 1000L
+            val timeSinceLastCheck = currentTimeMillis - lastCheckMillis
+
+            if (timeSinceLastCheck < oneDayInMillis) {
+                // Less than a day has passed, skip the check
+                return Success(null)
+            }
+        }
+
+        return getLatestEngineVersion()
             .flatMap { version ->
                 val latest: String =
                     version ?: return@flatMap Failure(MkException(IllegalStateException("Failed to fetch latest GeoIP DB release")))
                 val (isLatest, latestVersion) = isGeoIpDbLatest(latest)
                 if (isLatest) {
+                    // Update last check time even when already at latest version
+                    preferencesRepository.setValueByKey(
+                        SettingsKey.MMDB_LAST_CHECK,
+                        Clock.System.now().toEpochMilliseconds(),
+                    )
                     Success(null)
                 } else {
                     val url = buildGeoIpDbUrl(latestVersion)
@@ -58,6 +76,7 @@ class FetchGeoIpDbUpdates(
                         }
                 }
             }
+    }
 
     /**
      * Compare latest and current version integers and return pair of latest state and actual version number

composeApp/src/commonMain/kotlin/org/ooni/probe/domain/FetchGeoIpDbUpdates.kt

@@ -12,6 +12,7 @@ sqldelight = "2.1.0"
 dataStoreVersion = "1.1.4"
 junitKtx = "1.3.0"
 mokoPermissions = "0.20.1"
+ktor = "3.3.1"
 
 [plugins]
 
@@ -48,6 +49,10 @@ window-size = { module = "org.jetbrains.compose.material3:material3-window-size-
 back-handler = { module = "org.jetbrains.compose.ui:ui-backhandler", version.ref = "compose-plugin" }
 material-icons = { module = "org.jetbrains.compose.material:material-icons-core", version = "1.7.3" }
 dark-mode-detector = { module = "io.github.kdroidfilter:platformtools.darkmodedetector", version = "0.7.4" }
+ktor-client-core = { module = "io.ktor:ktor-client-core", version.ref = "ktor" }
+ktor-client-jvm = { module = "io.ktor:ktor-client-java", version.ref = "ktor" }
+ktor-client-okhttp = { module = "io.ktor:ktor-client-okhttp", version.ref = "ktor" }
+ktor-client-darwin = { module = "io.ktor:ktor-client-darwin", version.ref = "ktor" }
 
 # Preferences
 androidx-datastore-core-okio = { group = "androidx.datastore", name = "datastore-core-okio", version.ref = "dataStoreVersion" }
@@ -132,6 +137,7 @@ tooling = [
     "markdown",
     "kottie",
     "web-view",
+    "ktor-client-core",
 ]
 android = [
 #    "android-oonimkall",
@@ -140,6 +146,10 @@ android = [
     "android-work",
     "sqldelight-android",
     "android-appcompat",
+    "ktor-client-okhttp",
+]
+ios = [
+    "ktor-client-darwin"
 ]
 mobile = [
     "moko-permissions-compose",
@@ -151,7 +161,8 @@ desktop = [
     "directories",
     "auto-launch",
     "pratanumandal-unique",
-    "desktop-oonimkall"
+    "desktop-oonimkall",
+    "ktor-client-jvm",
 ]
 full = [
     "sentry",