Skip to content

Commit 548bfa9

Browse files
committed
Package the zlib.dll shipped with Python on Windows
1 parent 635fd52 commit 548bfa9

File tree

1 file changed

+13
-11
lines changed

1 file changed

+13
-11
lines changed

CMakeLists.txt

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -109,40 +109,42 @@ message(STATUS "Python_LIBRARY_DIRS: ${Python_LIBRARY_DIRS}")
109109

110110
if(MSVC)
111111
file(GLOB _pythondll "${Python_RUNTIME_LIBRARY_DIRS}/python3[0-9]*.dll")
112+
file(GLOB _zlib "${Python_RUNTIME_LIBRARY_DIRS}/zlib.dll")
112113

113-
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
114-
${CMAKE_COMMAND} -E copy ${_pythondll} ${GUI_BIN_DIR}/shared)
115114
if(COPY_PYTHON_DL)
116115
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
117116
${CMAKE_COMMAND} -E make_directory $<TARGET_FILE_DIR:${PLUGIN_NAME}>/shared)
118117

119118
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
120-
${CMAKE_COMMAND} -E copy ${_pythondll} $<TARGET_FILE_DIR:${PLUGIN_NAME}>/shared)
119+
${CMAKE_COMMAND} -E copy ${_pythondll} ${_zlib} $<TARGET_FILE_DIR:${PLUGIN_NAME}>/shared)
120+
else()
121+
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
122+
${CMAKE_COMMAND} -E copy ${_pythondll} ${_zlib} ${GUI_BIN_DIR}/shared)
121123
endif()
122124
elseif(LINUX)
123125
file(GLOB _pythonso "${Python_RUNTIME_LIBRARY_DIRS}/libpython3.[0-9]*.so.*.*")
124-
125-
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
126-
${CMAKE_COMMAND} -E copy ${_pythonso} ${GUI_BIN_DIR}/shared)
127126

128127
if(COPY_PYTHON_DL)
129128
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
130129
${CMAKE_COMMAND} -E make_directory $<TARGET_FILE_DIR:${PLUGIN_NAME}>/shared)
131130

132131
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
133132
${CMAKE_COMMAND} -E copy ${_pythonso} $<TARGET_FILE_DIR:${PLUGIN_NAME}>/shared)
133+
else()
134+
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
135+
${CMAKE_COMMAND} -E copy ${_pythonso} ${GUI_BIN_DIR}/shared)
134136
endif()
135137
elseif(APPLE)
136138
file(GLOB _pythondylib "${Python_RUNTIME_LIBRARY_DIRS}/libpython3.[0-9]*.dylib")
137139

138-
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
139-
${CMAKE_COMMAND} -E copy ${_pythondylib} $ENV{HOME}/Library/Application\ Support/open-ephys/shared-api8)
140-
141140
if(COPY_PYTHON_DL)
142141
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
143-
${CMAKE_COMMAND} -E make_directory $<TARGET_BUNDLE_DIR:${PLUGIN_NAME}>/shared)
142+
${CMAKE_COMMAND} -E make_directory $<TARGET_BUNDLE_DIR:${PLUGIN_NAME}>/../shared)
144143

145144
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
146-
${CMAKE_COMMAND} -E copy ${_pythondylib} $<TARGET_BUNDLE_DIR:${PLUGIN_NAME}>/shared)
145+
${CMAKE_COMMAND} -E copy ${_pythondylib} $<TARGET_BUNDLE_DIR:${PLUGIN_NAME}>/../shared)
146+
else()
147+
add_custom_command(TARGET ${PLUGIN_NAME} POST_BUILD COMMAND
148+
${CMAKE_COMMAND} -E copy ${_pythondylib} $ENV{HOME}/Library/Application\ Support/open-ephys/shared-api8)
147149
endif()
148150
endif()

0 commit comments

Comments
 (0)