Addressed review comments

bparks13 · bparks13 · commit 9e56cf0b4a82 · 2025-11-12T13:56:11.000-05:00
- Refactor file opening methods to use Type inputs instead of generics, allowing for a more flexible calling pattern
- Define an abstract Clone() method for ProbeGroups instead of using reflection to construct copied classes
- Brought Rhs2116 dialogs up to date with other dialogs, there were issues discovered during testing related to loading/saving files
diff --git a/OpenEphys.Onix1.Design/ChannelConfigurationDialog.cs b/OpenEphys.Onix1.Design/ChannelConfigurationDialog.cs
@@ -278,15 +278,16 @@ private void FormShown(object sender, EventArgs e)
             if (!TopLevel)
             {
                 menuStrip.Visible = false;
-                ResizeZedGraph();
             }
+
+            ResizeZedGraph();
         }
 
-        internal virtual bool OpenFile<T>() where T : ProbeGroup
+        internal virtual bool OpenFile(Type type)
         {
-            var newConfiguration = OpenAndParseConfigurationFile<T>();
+            var newConfiguration = OpenAndParseConfigurationFile(type);
 
-            if (ValidateProbeGroup(newConfiguration))
+            if (newConfiguration != null)
             {
                 ProbeGroup = newConfiguration;
                 return true;
@@ -317,7 +318,7 @@ internal bool ValidateProbeGroup(ProbeGroup newConfiguration)
             }
         }
 
-        internal T OpenAndParseConfigurationFile<T>() where T : ProbeGroup
+        internal ProbeGroup OpenAndParseConfigurationFile(Type type)
         {
             using OpenFileDialog ofd = new();
 
@@ -328,9 +329,9 @@ internal T OpenAndParseConfigurationFile<T>() where T : ProbeGroup
 
             if (ofd.ShowDialog() == DialogResult.OK && File.Exists(ofd.FileName))
             {
-                var newConfiguration = JsonHelper.DeserializeString<T>(File.ReadAllText(ofd.FileName));
+                var newConfiguration = ProbeInterfaceHelper.LoadExternalProbeInterfaceFile(ofd.FileName, type);
 
-                return newConfiguration;
+                return ValidateProbeGroup(newConfiguration) ? (ProbeGroup)newConfiguration : null;
             }
 
             return null;
@@ -1025,7 +1026,7 @@ void ResizeAxes()
 
         private void MenuItemOpenFile(object sender, EventArgs e)
         {
-            if (OpenFile<ProbeGroup>())
+            if (OpenFile(ProbeGroup.GetType()))
             {
                 DrawProbeGroup();
                 ResetZoom();
diff --git a/OpenEphys.Onix1.Design/NeuropixelsV1ChannelConfigurationDialog.cs b/OpenEphys.Onix1.Design/NeuropixelsV1ChannelConfigurationDialog.cs
@@ -58,12 +58,11 @@ internal override void LoadDefaultChannelLayout()
             OnFileOpenHandler();
         }
 
-        internal override bool OpenFile<T>()
+        internal override bool OpenFile(Type type)
         {
-            if (base.OpenFile<NeuropixelsV1eProbeGroup>())
+            if (base.OpenFile(type))
             {
                 ProbeConfiguration.ProbeGroup = (NeuropixelsV1eProbeGroup)ProbeGroup;
-
                 OnFileOpenHandler();
 
                 return true;
diff --git a/OpenEphys.Onix1.Design/NeuropixelsV2eChannelConfigurationDialog.cs b/OpenEphys.Onix1.Design/NeuropixelsV2eChannelConfigurationDialog.cs
@@ -24,7 +24,7 @@ public partial class NeuropixelsV2eChannelConfigurationDialog : ChannelConfigura
         /// </summary>
         /// <param name="probeConfiguration">A <see cref="NeuropixelsV2ProbeConfiguration"/> object holding the current configuration settings.</param>
         public NeuropixelsV2eChannelConfigurationDialog(NeuropixelsV2ProbeConfiguration probeConfiguration)
-            : base(probeConfiguration.ProbeGroup)
+            : base(probeConfiguration.ProbeGroup.Clone())
         {
             zedGraphChannels.ZoomButtons = MouseButtons.None;
             zedGraphChannels.ZoomButtons2 = MouseButtons.None;
@@ -54,23 +54,13 @@ internal override void LoadDefaultChannelLayout()
             OnFileOpenHandler();
         }
 
-        internal override bool OpenFile<T>()
+        internal override bool OpenFile(Type type)
         {
-            MethodInfo method = GetType().GetMethod(
-                nameof(OpenAndParseConfigurationFile),
-                BindingFlags.Instance | BindingFlags.NonPublic,
-                null,
-                Type.EmptyTypes,
-                null) ?? throw new InvalidOperationException($"Could not find the {nameof(OpenAndParseConfigurationFile)} method.");
-
-            MethodInfo genericMethod = method.MakeGenericMethod(ProbeGroup.GetType()) ?? throw new InvalidOperationException($"Could not create the generic {nameof(OpenAndParseConfigurationFile)} method.");
-
-            var newConfiguration = genericMethod.Invoke(this, null) as NeuropixelsV2eProbeGroup;
-
-            if (ValidateProbeGroup(newConfiguration))
+            if (base.OpenFile(type))
             {
-                ProbeGroup = newConfiguration;
+                ProbeConfiguration.ProbeGroup = (NeuropixelsV2eProbeGroup)ProbeGroup;
                 OnFileOpenHandler();
+
                 return true;
             }
 
@@ -80,7 +70,6 @@ internal override bool OpenFile<T>()
         private void OnFileOpenHandler()
         {
             OnFileLoad?.Invoke(this, EventArgs.Empty);
-            ProbeConfiguration.ProbeGroup = (NeuropixelsV2eProbeGroup)ProbeGroup;
         }
 
         internal override void ZoomEvent(ZedGraphControl sender, ZoomState oldState, ZoomState newState)
diff --git a/OpenEphys.Onix1.Design/Rhs2116ChannelConfigurationDialog.cs b/OpenEphys.Onix1.Design/Rhs2116ChannelConfigurationDialog.cs
@@ -13,6 +13,7 @@ public partial class Rhs2116ChannelConfigurationDialog : ChannelConfigurationDia
     {
         internal event EventHandler OnSelect;
         internal event EventHandler OnZoom;
+        internal event EventHandler OnFileLoad;
 
         /// <summary>
         /// Initializes a new instance of <see cref="Rhs2116ChannelConfigurationDialog"/>.
@@ -36,14 +37,33 @@ public Rhs2116ChannelConfigurationDialog(Rhs2116ProbeGroup probeGroup)
             RefreshZedGraph();
         }
 
+        internal override void LoadDefaultChannelLayout()
+        {
+            ProbeGroup = DefaultChannelLayout();
+
+            OnFileOpenHandler();
+        }
+
         internal override ProbeGroup DefaultChannelLayout()
         {
             return new Rhs2116ProbeGroup();
         }
 
-        internal override bool OpenFile<T>()
+        internal override bool OpenFile(Type type)
+        {
+            if (base.OpenFile(type))
+            {
+                OnFileOpenHandler();
+
+                return true;
+            }
+
+            return false;
+        }
+
+        void OnFileOpenHandler()
         {
-            return base.OpenFile<Rhs2116ProbeGroup>();
+            OnFileLoad?.Invoke(this, EventArgs.Empty);
         }
 
         internal override void SelectedContactChanged()
diff --git a/OpenEphys.Onix1.Design/Rhs2116StimulusSequenceDialog.cs b/OpenEphys.Onix1.Design/Rhs2116StimulusSequenceDialog.cs
@@ -71,8 +71,7 @@ public Rhs2116StimulusSequenceDialog(ConfigureRhs2116Trigger rhs2116Trigger)
 
             ChannelDialog.OnSelect += OnSelect;
             ChannelDialog.OnZoom += OnZoom;
-
-            ChannelDialog.Show();
+            ChannelDialog.OnFileLoad += OnFileLoad;
 
             StimulusSequenceOptions = new();
             groupBoxDefineStimuli.Controls.Add(StimulusSequenceOptions.SetChildFormProperties(this));
@@ -115,6 +114,11 @@ public Rhs2116StimulusSequenceDialog(ConfigureRhs2116Trigger rhs2116Trigger)
             DrawStimulusWaveform();
         }
 
+        void OnFileLoad(object sender, EventArgs e)
+        {
+            Trigger.ProbeGroup = (Rhs2116ProbeGroup)ChannelDialog.ProbeGroup;
+        }
+
         internal void OnZoom(object sender, EventArgs e)
         {
             ChannelDialog.UpdateFontSize();
@@ -885,9 +889,7 @@ internal override bool IsSequenceValid()
 
         internal override void DeserializeStimulusSequence(string fileName)
         {
-            var newSequence = JsonHelper.DeserializeString<Rhs2116StimulusSequencePair>(File.ReadAllText(fileName));
-
-            if (newSequence != null && newSequence.Stimuli.Length == 32)
+            if (JsonHelper.DeserializeString(File.ReadAllText(fileName), typeof(Rhs2116StimulusSequencePair)) is Rhs2116StimulusSequencePair newSequence && newSequence.Stimuli.Length == 32)
             {
                 if (newSequence == new Rhs2116StimulusSequencePair())
                 {
diff --git a/OpenEphys.Onix1/JsonHelper.cs b/OpenEphys.Onix1/JsonHelper.cs
@@ -7,7 +7,7 @@ namespace OpenEphys.Onix1
 {
     internal static class JsonHelper
     {
-        public static T DeserializeString<T>(string jsonString) where T : class
+        public static object DeserializeString(string jsonString, Type type)
         {
             var errors = new List<string>();
 
@@ -22,7 +22,7 @@ public static T DeserializeString<T>(string jsonString) where T : class
 
             try
             {
-                var obj = JsonConvert.DeserializeObject<T>(jsonString, serializerSettings);
+                var obj = JsonConvert.DeserializeObject(jsonString, type, serializerSettings);
 
                 if (errors.Count > 0)
                 {
diff --git a/OpenEphys.Onix1/NeuropixelsV1ProbeConfiguration.cs b/OpenEphys.Onix1/NeuropixelsV1ProbeConfiguration.cs
@@ -266,7 +266,7 @@ public string ProbeInterfaceLoadFileName
                     if (string.IsNullOrEmpty(probeInterfaceFileName))
                         return new NeuropixelsV1eProbeGroup();
 
-                    return ProbeInterfaceHelper.LoadExternalProbeInterfaceFile<NeuropixelsV1eProbeGroup>(probeInterfaceFileName);
+                    return ProbeInterfaceHelper.LoadExternalProbeInterfaceFile(probeInterfaceFileName, typeof(NeuropixelsV1eProbeGroup)) as NeuropixelsV1eProbeGroup;
                 });
             }
         }
diff --git a/OpenEphys.Onix1/NeuropixelsV2QuadShankProbeConfiguration.cs b/OpenEphys.Onix1/NeuropixelsV2QuadShankProbeConfiguration.cs
@@ -72,7 +72,7 @@ public NeuropixelsV2QuadShankProbeConfiguration(NeuropixelsV2Probe probe, Neurop
         public NeuropixelsV2QuadShankProbeConfiguration(NeuropixelsV2QuadShankProbeConfiguration probeConfiguration)
         {
             Reference = probeConfiguration.Reference;
-            ProbeGroup = probeConfiguration.ProbeGroup.Clone<NeuropixelsV2eQuadShankProbeGroup>();
+            ProbeGroup = probeConfiguration.ProbeGroup.Clone();
             Probe = probeConfiguration.Probe;
         }
 
@@ -86,7 +86,7 @@ public NeuropixelsV2QuadShankProbeConfiguration(NeuropixelsV2QuadShankProbeConfi
         [JsonConstructor]
         public NeuropixelsV2QuadShankProbeConfiguration(NeuropixelsV2eQuadShankProbeGroup probeGroup, NeuropixelsV2Probe probe, NeuropixelsV2QuadShankReference reference)
         {
-            ProbeGroup = probeGroup.Clone<NeuropixelsV2eQuadShankProbeGroup>();
+            ProbeGroup = probeGroup.Clone();
             Reference = reference;
             Probe = probe;
         }
diff --git a/OpenEphys.Onix1/NeuropixelsV2eProbeGroup.cs b/OpenEphys.Onix1/NeuropixelsV2eProbeGroup.cs
@@ -31,10 +31,7 @@ public NeuropixelsV2eProbeGroup(NeuropixelsV2eProbeGroup probeGroup)
         {
         }
 
-        internal NeuropixelsV2eProbeGroup Clone<T>() where T : NeuropixelsV2eProbeGroup
-        {
-            return Activator.CreateInstance(typeof(T), Specification, Version, Probes.Select(probe => new Probe(probe)).ToArray()) as T ?? throw new NullReferenceException($"Issue creating new probe group of type {nameof(NeuropixelsV2eProbeGroup)}.");
-        }
+        internal abstract NeuropixelsV2eProbeGroup Clone();
 
         internal void UpdateDeviceChannelIndices(NeuropixelsV2Electrode[] channelMap)
         {
diff --git a/OpenEphys.Onix1/NeuropixelsV2eQuadShankProbeGroup.cs b/OpenEphys.Onix1/NeuropixelsV2eQuadShankProbeGroup.cs
@@ -74,6 +74,11 @@ public NeuropixelsV2eQuadShankProbeGroup(NeuropixelsV2eQuadShankProbeGroup probe
         {
         }
 
+        internal override NeuropixelsV2eProbeGroup Clone()
+        {
+            return new NeuropixelsV2eQuadShankProbeGroup(Specification, Version, Probes.Select(probe => new Probe(probe)).ToArray());
+        }
+
         /// <summary>
         /// Generates a 2D array of default contact positions based on the given number of channels.
         /// </summary>
diff --git a/OpenEphys.Onix1/ProbeInterfaceHelper.cs b/OpenEphys.Onix1/ProbeInterfaceHelper.cs
@@ -8,7 +8,7 @@ internal static class ProbeInterfaceHelper
     {
         public const string ProbeInterfaceFileNameFilter = "ProbeInterface Files|*.json|All Files|*.*";
 
-        public static T LoadExternalProbeInterfaceFile<T>(string probeInterfaceFileName) where T : ProbeGroup
+        public static ProbeGroup LoadExternalProbeInterfaceFile(string probeInterfaceFileName, Type type)
         {
             if (string.IsNullOrEmpty(probeInterfaceFileName))
             {
@@ -23,8 +23,8 @@ public static T LoadExternalProbeInterfaceFile<T>(string probeInterfaceFileName)
             try
             {
                 string jsonContent = File.ReadAllText(probeInterfaceFileName);
-                var result = JsonHelper.DeserializeString<T>(jsonContent) ?? throw new InvalidDataException($"Failed to parse ProbeInterface file: {probeInterfaceFileName}");
-                return result;
+                var result = JsonHelper.DeserializeString(jsonContent, type) ?? throw new InvalidDataException($"Failed to parse ProbeInterface file: {probeInterfaceFileName}");
+                return (ProbeGroup)result;
             }
             catch (UnauthorizedAccessException e)
             {

Original file line number	Diff line number	Diff line change
`@@ -278,15 +278,16 @@ private void FormShown(object sender, EventArgs e)`
`278`	`278`	`if (!TopLevel)`
`279`	`279`	`{`
`280`	`280`	`menuStrip.Visible = false;`
`281`		`- ResizeZedGraph();`
`282`	`281`	`}`
	`282`	`+`
	`283`	`+ ResizeZedGraph();`
`283`	`284`	`}`
`284`	`285`
`285`		`- internal virtual bool OpenFile<T>() where T : ProbeGroup`
	`286`	`+ internal virtual bool OpenFile(Type type)`
`286`	`287`	`{`
`287`		`- var newConfiguration = OpenAndParseConfigurationFile<T>();`
	`288`	`+ var newConfiguration = OpenAndParseConfigurationFile(type);`
`288`	`289`
`289`		`- if (ValidateProbeGroup(newConfiguration))`
	`290`	`+ if (newConfiguration != null)`
`290`	`291`	`{`
`291`	`292`	`ProbeGroup = newConfiguration;`
`292`	`293`	`return true;`
`@@ -317,7 +318,7 @@ internal bool ValidateProbeGroup(ProbeGroup newConfiguration)`
`317`	`318`	`}`
`318`	`319`	`}`
`319`	`320`
`320`		`- internal T OpenAndParseConfigurationFile<T>() where T : ProbeGroup`
	`321`	`+ internal ProbeGroup OpenAndParseConfigurationFile(Type type)`
`321`	`322`	`{`
`322`	`323`	`using OpenFileDialog ofd = new();`
`323`	`324`
`@@ -328,9 +329,9 @@ internal T OpenAndParseConfigurationFile<T>() where T : ProbeGroup`
`328`	`329`
`329`	`330`	`if (ofd.ShowDialog() == DialogResult.OK && File.Exists(ofd.FileName))`
`330`	`331`	`{`
`331`		`- var newConfiguration = JsonHelper.DeserializeString<T>(File.ReadAllText(ofd.FileName));`
	`332`	`+ var newConfiguration = ProbeInterfaceHelper.LoadExternalProbeInterfaceFile(ofd.FileName, type);`
`332`	`333`
`333`		`- return newConfiguration;`
	`334`	`+ return ValidateProbeGroup(newConfiguration) ? (ProbeGroup)newConfiguration : null;`
`334`	`335`	`}`
`335`	`336`
`336`	`337`	`return null;`
`@@ -1025,7 +1026,7 @@ void ResizeAxes()`
`1025`	`1026`
`1026`	`1027`	`private void MenuItemOpenFile(object sender, EventArgs e)`
`1027`	`1028`	`{`
`1028`		`- if (OpenFile<ProbeGroup>())`
	`1029`	`+ if (OpenFile(ProbeGroup.GetType()))`
`1029`	`1030`	`{`
`1030`	`1031`	`DrawProbeGroup();`
`1031`	`1032`	`ResetZoom();`
Original file line number	Diff line number	Diff line change
`@@ -58,12 +58,11 @@ internal override void LoadDefaultChannelLayout()`
`58`	`58`	`OnFileOpenHandler();`
`59`	`59`	`}`
`60`	`60`
`61`		`- internal override bool OpenFile<T>()`
	`61`	`+ internal override bool OpenFile(Type type)`
`62`	`62`	`{`
`63`		`- if (base.OpenFile<NeuropixelsV1eProbeGroup>())`
	`63`	`+ if (base.OpenFile(type))`
`64`	`64`	`{`
`65`	`65`	`ProbeConfiguration.ProbeGroup = (NeuropixelsV1eProbeGroup)ProbeGroup;`
`66`		`-`
`67`	`66`	`OnFileOpenHandler();`
`68`	`67`
`69`	`68`	`return true;`
Original file line number	Diff line number	Diff line change
`@@ -71,8 +71,7 @@ public Rhs2116StimulusSequenceDialog(ConfigureRhs2116Trigger rhs2116Trigger)`
`71`	`71`
`72`	`72`	`ChannelDialog.OnSelect += OnSelect;`
`73`	`73`	`ChannelDialog.OnZoom += OnZoom;`
`74`		`-`
`75`		`- ChannelDialog.Show();`
	`74`	`+ ChannelDialog.OnFileLoad += OnFileLoad;`
`76`	`75`
`77`	`76`	`StimulusSequenceOptions = new();`
`78`	`77`	`groupBoxDefineStimuli.Controls.Add(StimulusSequenceOptions.SetChildFormProperties(this));`
`@@ -115,6 +114,11 @@ public Rhs2116StimulusSequenceDialog(ConfigureRhs2116Trigger rhs2116Trigger)`
`115`	`114`	`DrawStimulusWaveform();`
`116`	`115`	`}`
`117`	`116`
	`117`	`+ void OnFileLoad(object sender, EventArgs e)`
	`118`	`+ {`
	`119`	`+ Trigger.ProbeGroup = (Rhs2116ProbeGroup)ChannelDialog.ProbeGroup;`
	`120`	`+ }`
	`121`	`+`
`118`	`122`	`internal void OnZoom(object sender, EventArgs e)`
`119`	`123`	`{`
`120`	`124`	`ChannelDialog.UpdateFontSize();`
`@@ -885,9 +889,7 @@ internal override bool IsSequenceValid()`
`885`	`889`
`886`	`890`	`internal override void DeserializeStimulusSequence(string fileName)`
`887`	`891`	`{`
`888`		`- var newSequence = JsonHelper.DeserializeString<Rhs2116StimulusSequencePair>(File.ReadAllText(fileName));`
`889`		`-`
`890`		`- if (newSequence != null && newSequence.Stimuli.Length == 32)`
	`892`	`+ if (JsonHelper.DeserializeString(File.ReadAllText(fileName), typeof(Rhs2116StimulusSequencePair)) is Rhs2116StimulusSequencePair newSequence && newSequence.Stimuli.Length == 32)`
`891`	`893`	`{`
`892`	`894`	`if (newSequence == new Rhs2116StimulusSequencePair())`
`893`	`895`	`{`
Original file line number	Diff line number	Diff line change
`@@ -7,7 +7,7 @@ namespace OpenEphys.Onix1`
`7`	`7`	`{`
`8`	`8`	`internal static class JsonHelper`
`9`	`9`	`{`
`10`		`- public static T DeserializeString<T>(string jsonString) where T : class`
	`10`	`+ public static object DeserializeString(string jsonString, Type type)`
`11`	`11`	`{`
`12`	`12`	`var errors = new List<string>();`
`13`	`13`
`@@ -22,7 +22,7 @@ public static T DeserializeString<T>(string jsonString) where T : class`
`22`	`22`
`23`	`23`	`try`
`24`	`24`	`{`
`25`		`- var obj = JsonConvert.DeserializeObject<T>(jsonString, serializerSettings);`
	`25`	`+ var obj = JsonConvert.DeserializeObject(jsonString, type, serializerSettings);`
`26`	`26`
`27`	`27`	`if (errors.Count > 0)`
`28`	`28`	`{`
Original file line number	Diff line number	Diff line change
`@@ -266,7 +266,7 @@ public string ProbeInterfaceLoadFileName`
`266`	`266`	`if (string.IsNullOrEmpty(probeInterfaceFileName))`
`267`	`267`	`return new NeuropixelsV1eProbeGroup();`
`268`	`268`
`269`		`- return ProbeInterfaceHelper.LoadExternalProbeInterfaceFile<NeuropixelsV1eProbeGroup>(probeInterfaceFileName);`
	`269`	`+ return ProbeInterfaceHelper.LoadExternalProbeInterfaceFile(probeInterfaceFileName, typeof(NeuropixelsV1eProbeGroup)) as NeuropixelsV1eProbeGroup;`
`270`	`270`	`});`
`271`	`271`	`}`
`272`	`272`	`}`
Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ public NeuropixelsV2QuadShankProbeConfiguration(NeuropixelsV2Probe probe, Neurop`
`72`	`72`	`public NeuropixelsV2QuadShankProbeConfiguration(NeuropixelsV2QuadShankProbeConfiguration probeConfiguration)`
`73`	`73`	`{`
`74`	`74`	`Reference = probeConfiguration.Reference;`
`75`		`- ProbeGroup = probeConfiguration.ProbeGroup.Clone<NeuropixelsV2eQuadShankProbeGroup>();`
	`75`	`+ ProbeGroup = probeConfiguration.ProbeGroup.Clone();`
`76`	`76`	`Probe = probeConfiguration.Probe;`
`77`	`77`	`}`
`78`	`78`
`@@ -86,7 +86,7 @@ public NeuropixelsV2QuadShankProbeConfiguration(NeuropixelsV2QuadShankProbeConfi`
`86`	`86`	`[JsonConstructor]`
`87`	`87`	`public NeuropixelsV2QuadShankProbeConfiguration(NeuropixelsV2eQuadShankProbeGroup probeGroup, NeuropixelsV2Probe probe, NeuropixelsV2QuadShankReference reference)`
`88`	`88`	`{`
`89`		`- ProbeGroup = probeGroup.Clone<NeuropixelsV2eQuadShankProbeGroup>();`
	`89`	`+ ProbeGroup = probeGroup.Clone();`
`90`	`90`	`Reference = reference;`
`91`	`91`	`Probe = probe;`
`92`	`92`	`}`
Original file line number	Diff line number	Diff line change
`@@ -31,10 +31,7 @@ public NeuropixelsV2eProbeGroup(NeuropixelsV2eProbeGroup probeGroup)`
`31`	`31`	`{`
`32`	`32`	`}`
`33`	`33`
`34`		`- internal NeuropixelsV2eProbeGroup Clone<T>() where T : NeuropixelsV2eProbeGroup`
`35`		`- {`
`36`		`- return Activator.CreateInstance(typeof(T), Specification, Version, Probes.Select(probe => new Probe(probe)).ToArray()) as T ?? throw new NullReferenceException($"Issue creating new probe group of type {nameof(NeuropixelsV2eProbeGroup)}.");`
`37`		`- }`
	`34`	`+ internal abstract NeuropixelsV2eProbeGroup Clone();`
`38`	`35`
`39`	`36`	`internal void UpdateDeviceChannelIndices(NeuropixelsV2Electrode[] channelMap)`
`40`	`37`	`{`
Original file line number	Diff line number	Diff line change
`@@ -74,6 +74,11 @@ public NeuropixelsV2eQuadShankProbeGroup(NeuropixelsV2eQuadShankProbeGroup probe`
`74`	`74`	`{`
`75`	`75`	`}`
`76`	`76`
	`77`	`+ internal override NeuropixelsV2eProbeGroup Clone()`
	`78`	`+ {`
	`79`	`+ return new NeuropixelsV2eQuadShankProbeGroup(Specification, Version, Probes.Select(probe => new Probe(probe)).ToArray());`
	`80`	`+ }`
	`81`	`+`
`77`	`82`	`/// <summary>`
`78`	`83`	`/// Generates a 2D array of default contact positions based on the given number of channels.`
`79`	`84`	`/// </summary>`