Skip to content

Commit 405c776

Browse files
PR suggestion: make HookSupportData a real POJO
1 parent 54ef290 commit 405c776

File tree

3 files changed

+19
-11
lines changed

3 files changed

+19
-11
lines changed

src/main/java/dev/openfeature/sdk/HookSupport.java

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,11 @@ public void updateEvaluationContext(HookSupportData hookSupportData, EvaluationC
3333
* created
3434
* @param evaluationContext the evaluation context which is
3535
*/
36-
public void setHookSupportDataHooks(HookSupportData hookSupportData, List<Hook> hooks,
37-
SharedHookContext sharedContext, EvaluationContext evaluationContext) {
36+
public void setHookSupportDataHooks(
37+
HookSupportData hookSupportData,
38+
List<Hook> hooks,
39+
SharedHookContext sharedContext,
40+
EvaluationContext evaluationContext) {
3841
List<Pair<Hook, HookContext>> hookContextPairs = new ArrayList<>();
3942
for (Hook hook : hooks) {
4043
if (hook.supportsFlagValueType(sharedContext.getType())) {

src/main/java/dev/openfeature/sdk/HookSupportData.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,4 @@ class HookSupportData {
1515
Map<String, Object> hints;
1616

1717
HookSupportData() {}
18-
1918
}

src/test/java/dev/openfeature/sdk/HookSupportTest.java

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,8 @@ void shouldMergeEvaluationContextsOnBeforeHooksCorrectly() {
3535

3636
var sharedContext = getBaseHookContextForType(FlagValueType.STRING);
3737
var hookSupportData = new HookSupportData();
38-
hookSupport.setHookSupportDataHooks(hookSupportData,
39-
Arrays.asList(hook1, hook2), sharedContext, baseEvalContext);
38+
hookSupport.setHookSupportDataHooks(
39+
hookSupportData, Arrays.asList(hook1, hook2), sharedContext, baseEvalContext);
4040
hookSupport.updateEvaluationContext(hookSupportData, baseEvalContext);
4141

4242
hookSupport.executeBeforeHooks(hookSupportData);
@@ -55,8 +55,11 @@ void shouldAlwaysCallGenericHook(FlagValueType flagValueType) {
5555
Hook<?> genericHook = mockGenericHook();
5656

5757
var hookSupportData = new HookSupportData();
58-
hookSupport.setHookSupportDataHooks(hookSupportData,
59-
List.of(genericHook), getBaseHookContextForType(flagValueType), ImmutableContext.EMPTY);
58+
hookSupport.setHookSupportDataHooks(
59+
hookSupportData,
60+
List.of(genericHook),
61+
getBaseHookContextForType(flagValueType),
62+
ImmutableContext.EMPTY);
6063

6164
callAllHooks(hookSupportData);
6265

@@ -72,8 +75,8 @@ void shouldAlwaysCallGenericHook(FlagValueType flagValueType) {
7275
void shouldPassDataAcrossStages(FlagValueType flagValueType) {
7376
var testHook = new TestHookWithData();
7477
var hookSupportData = new HookSupportData();
75-
hookSupport.setHookSupportDataHooks(hookSupportData,
76-
List.of(testHook), getBaseHookContextForType(flagValueType), ImmutableContext.EMPTY);
78+
hookSupport.setHookSupportDataHooks(
79+
hookSupportData, List.of(testHook), getBaseHookContextForType(flagValueType), ImmutableContext.EMPTY);
7780

7881
hookSupport.executeBeforeHooks(hookSupportData);
7982
assertHookData(testHook, "before");
@@ -98,8 +101,11 @@ void shouldIsolateDataBetweenHooks(FlagValueType flagValueType) {
98101
var testHook2 = new TestHookWithData(2);
99102

100103
var hookSupportData = new HookSupportData();
101-
hookSupport.setHookSupportDataHooks(hookSupportData,
102-
List.of(testHook1, testHook2), getBaseHookContextForType(flagValueType), ImmutableContext.EMPTY);
104+
hookSupport.setHookSupportDataHooks(
105+
hookSupportData,
106+
List.of(testHook1, testHook2),
107+
getBaseHookContextForType(flagValueType),
108+
ImmutableContext.EMPTY);
103109

104110
callAllHooks(hookSupportData);
105111

0 commit comments

Comments
 (0)