fixup: test improvements

Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>

Author: aepfli

src/test/java/dev/openfeature/sdk/DeveloperExperienceTest.java

@@ -15,14 +15,21 @@
 import java.util.Map;
 import java.util.Optional;
 import lombok.SneakyThrows;
+import org.junit.jupiter.api.BeforeEach;
 import org.junit.jupiter.api.Test;
 
 class DeveloperExperienceTest implements HookFixtures {
     transient String flagKey = "mykey";
+    private OpenFeatureAPI api;
+
+    @BeforeEach
+    public void setUp() throws Exception {
+        api = new OpenFeatureAPI();
+
+    }
 
     @Test
     void simpleBooleanFlag() {
-        OpenFeatureAPI api = new OpenFeatureAPI();
         api.setProviderAndWait(new TestEventsProvider());
         Client client = api.getClient();
         Boolean retval = client.getBooleanValue(flagKey, false);
@@ -33,7 +40,6 @@ void simpleBooleanFlag() {
     void clientHooks() {
         Hook<Boolean> exampleHook = mockBooleanHook();
 
-        OpenFeatureAPI api = new OpenFeatureAPI();
         api.setProviderAndWait(new TestEventsProvider());
         Client client = api.getClient();
         client.addHooks(exampleHook);
@@ -47,7 +53,6 @@ void evalHooks() {
         Hook<Boolean> clientHook = mockBooleanHook();
         Hook<Boolean> evalHook = mockBooleanHook();
 
-        OpenFeatureAPI api = new OpenFeatureAPI();
         api.setProviderAndWait(new TestEventsProvider());
         Client client = api.getClient();
         client.addHooks(clientHook);
@@ -68,7 +73,6 @@ void evalHooks() {
     @Test
     void providingContext() {
 
-        OpenFeatureAPI api = new OpenFeatureAPI();
         api.setProviderAndWait(new TestEventsProvider());
         Client client = api.getClient();
         Map<String, Value> attributes = new HashMap<>();
@@ -85,7 +89,6 @@ void providingContext() {
 
     @Test
     void brokenProvider() {
-        OpenFeatureAPI api = new OpenFeatureAPI();
         api.setProviderAndWait(new AlwaysBrokenProvider());
         Client client = api.getClient();
         FlagEvaluationDetails<Boolean> retval = client.getBooleanDetails(flagKey, false);
@@ -132,7 +135,6 @@ public Optional before(HookContext ctx, Map hints) {
     @Test
     void setProviderAndWaitShouldPutTheProviderInReadyState() {
         String domain = "domain";
-        OpenFeatureAPI api = new OpenFeatureAPI();
         api.setProviderAndWait(domain, new TestEventsProvider());
         Client client = api.getClient(domain);
         assertThat(client.getProviderState()).isEqualTo(ProviderState.READY);
@@ -145,7 +147,6 @@ void setProviderAndWaitShouldPutTheProviderInReadyState() {
     @Test
     void shouldPutTheProviderInStateErrorAfterEmittingErrorEvent() {
         String domain = "domain";
-        OpenFeatureAPI api = new OpenFeatureAPI();
         TestEventsProvider provider = new TestEventsProvider();
         api.setProviderAndWait(domain, provider);
         Client client = api.getClient(domain);
@@ -161,7 +162,6 @@ void shouldPutTheProviderInStateErrorAfterEmittingErrorEvent() {
     @Test
     void shouldPutTheProviderInStateStaleAfterEmittingStaleEvent() {
         String domain = "domain";
-        OpenFeatureAPI api = new OpenFeatureAPI();
         TestEventsProvider provider = new TestEventsProvider();
         api.setProviderAndWait(domain, provider);
         Client client = api.getClient(domain);
@@ -177,7 +177,6 @@ void shouldPutTheProviderInStateStaleAfterEmittingStaleEvent() {
     @Test
     void shouldPutTheProviderInStateReadyAfterEmittingReadyEvent() {
         String domain = "domain";
-        OpenFeatureAPI api = new OpenFeatureAPI();
         TestEventsProvider provider = new TestEventsProvider();
         api.setProviderAndWait(domain, provider);
         Client client = api.getClient(domain);