Skip to content

semconv update process did not catch the removal of a METRIC_ export #5968

@trentm

Description

@trentm

Semconv v1.37.0 removed system.network.dropped and system.network.packets while renaming them. (IIUC they should have been deprecated, instead. I'll follow-up on the semantic-conventions repo separately: open-telemetry/semantic-conventions#2828) The issue here is that I would have hoped that the semconv update process here -- perhaps a lint guard, or the scripts/semconv/changelog-gen.js script -- would have caught this.

This shows that the commit for the v1.37.0 semconv update removed the METRIC_SYSTEM_NETWORK_DROPPED export with no mention in the changelog.

% git show 747da911759caa1f9c434eaf0a4a024fa2bbcea6 | rg DROPPED
+METRIC_SYSTEM_NETWORK_PACKET_DROPPED                                              // system.network.packet.dropped
-export const METRIC_SYSTEM_NETWORK_DROPPED = 'system.network.dropped' as const;
+export const METRIC_SYSTEM_NETWORK_PACKET_DROPPED = 'system.network.packet.dropped' as const;

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions