Redis instrumentation is not following semconv

[thompson-tomo]

The problem

The implementation of the redis instrumentation is currently using the following attributes but they are not defined in the messaging namespace but there is attributes which should be used

• net.peer.name
• net.peer.port

Solution

Update the attribute keys being used

[github-actions]

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

[adeyinkaezra123]

Hi @thompson-tomo and @kaylareopelle, I'd like to give this a shot. Can you assign it to me?

[kaylareopelle]

Hi @adeyinkaezra123, sure thing! This is a little more complicated than the solution in the issue description currently describes.

AFAIK, Redis instrumentation is part of the database semantic conventions, not the messaging conventions (@thompson-tomo, please correct me if you've seen something else).

Here's a full rundown of the Redis conventions: https://opentelemetry.io/docs/specs/semconv/database/redis/

Currently, the opentelemetry-instrumentation-redis gem uses an unstable version of the semantic conventions. The DB conventions are now stable and there is a path to migrate to the stable conventions.

This migration path involves incorporating the OTEL_SEMCONV_STABILITY_OPT_IN environment variable into the instrumentation so that users can choose to send the old conventions, the stable conventions, or both.

#1547 is an example of how we handled this for an HTTP client. It's a lot of duplication, but it's temporary. After the environment variable has been available to users for six months, we can remove it and send only the stable conventions.

If adding the full environment variable/triple module approach is more than you can take on, let me know and I'll see if we can find a way to reduce the scope.

cc @hannahramadan who's been working on the migration for HTTP and is starting on DB migration for SQL libraries.