-
Couldn't load subscription status.
- Fork 223
Open
Labels
help wantedExtra attention is neededExtra attention is neededinstrumentationkeepEnsures stale-bot keeps this issue/PR openEnsures stale-bot keeps this issue/PR open
Description
During the SIG meeting on 2024-04-30, I brought up a few challenges of working with the existing ActiveSupport instrumentation, that were brought to our attention while instrumenting ActionMailer: #887
There were issues with missing options, implementation and naming that makes it difficult to use and potentially error prone. The list below includes some of the changes I would like to see:
- Support Setting Span Kind feat: ActiveSupport user specified span kind #1016
- Default to using the AS event name instead of splitting and inverting event names
- Allow users to provide a proc that formats the span name feat!: Custom ActiveSupport Span Names #1014
- Ingress/egress spans should default to the semantic conventions; while internal spans default to AS event name
- Switch to allow lists instead of deny (
disallow...) lists and default to excluding PII - Prevent users from mutating the ActiveSupport payload when extracting span attributes in
notification_payload_transform - Map Rails key names to semantic convention key names
Metadata
Metadata
Assignees
Labels
help wantedExtra attention is neededExtra attention is neededinstrumentationkeepEnsures stale-bot keeps this issue/PR openEnsures stale-bot keeps this issue/PR open