[Bug]: Remove circular dependency from core repo

[bantonsson]

What happened?

The opentelemetry-tracing-appender depends on tracing-opentelemetry that depends on opentelemetry.

As things are now, I can't open a PR for removing fields in the SpanBuilder in the core repo until I have removed their use in the tracing-opentelemetry repo, and there has been a dot release of tracing-opentelemetry, since the appender in the core repo will fail to build otherwise.

Moving the appender out of the core repo and not having any dependencies on the appender in the core repo would mean that we can release the core repo artifacts without commenting out anything. Then the tracing-opentelemetry repo can release their artifacts, and then the appender can be released. Just like normal dependencies should work.

The current state is not maintainable.

OpenTelemetry API Version (i.e version of opentelemetry crate)

0.31

OpenTelemetry SDK Version (i.e version of opentelemetry_sdk crate)

0.31

What Exporter(s) are you seeing the problem on?

No response

Relevant log output

Tip

_{React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.}

[cijothomas]

opentelemetry-tracing-appender depends on tracing-opentelemetry

Let's remove this dependency. It was only added temporarily. Now that tracing-opentelemetry can properly activate OTel Span context, users can leverage than, instead of this hack right?

(I am not opposed to moving appenders to contrib. We should be able to move both appenders out to contrib, like other Otel repos. That can be done in a future date.)

[bantonsson]

I think it should be fine, but I'm not entirely sure about the extra traversing to find the parent of the tracing span. If that is needed in case there is some filtering happening. Even if we remove that code, the circularity still exists for the tests since they use tracing-opentelemetry.

I can open a PR that removes the use in the code, but not the tests, since then the feature won't be tested 🤷🏼‍♂️

[lalitb]

Even if we remove that code, the circularity still exists for the tests since they use tracing-opentelemetry.

The integration test tracing_appender_inside_tracing_crate_context() should ideally be moved to the tracing-opentelemetry repo since it tests that tracing-opentelemetry correctly populates the OpenTelemetry Context for downstream. The current crate needn't know the existence of tracing-opentelemetry.

[cijothomas]

Even if we remove that code, the circularity still exists for the tests since they use tracing-opentelemetry.

The integration test tracing_appender_inside_tracing_crate_context() should ideally be moved to the tracing-opentelemetry repo since it tests that tracing-opentelemetry correctly populates the OpenTelemetry Context for downstream. The current crate needn't know the existence of tracing-opentelemetry.

+1. There should not be any need for testing tracing-opentelemetry functionality here.