Telegram module: Add new Angular based frontend #359
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr integrates the new Angular based Telegram module frontend.
Since it is no longer possible with openITCOCKPIT 5 to simply inject your own module frontend parts, as was the case with oitc 4, it would be nice to have the migrated Telegram module frontend as part of the packaged and compiled, productive frontend.
Only if the Telegram module itself is placed in plugins, the corresponding frontend part is accessible via the menu link. So it shouldn't harm anything.
The separation of the frontend from the actual module repository unfortunately makes it more difficult to maintain, but I don't see any other working solution to make the module frontend easily accessible in productive instances than having it here.