-
Notifications
You must be signed in to change notification settings - Fork 71
Consolidate multiple commits into one: Add PVC manager functionality and Fix xfs_qouta clear projid #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
Hi @laik. I'm yet to review your PR. Just letting you know that we require DCO signatures on all commits. You might have already noticed the failing CI job. |
…and related fixes Signed-off-by: laik <laik.lj@me.com>
Yes, I saw it, it was added |
Signed-off-by: laik <laik.lj@me.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #290 +/- ##
===========================================
+ Coverage 37.91% 39.18% +1.26%
===========================================
Files 36 1 -35
Lines 3373 684 -2689
===========================================
- Hits 1279 268 -1011
+ Misses 2012 407 -1605
+ Partials 82 9 -73
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Empty commit to trigger CI build Signed-off-by: laik <laik.lj@me.com>
The pvc-manager Dockerfile expects the binary to be present in the build context, but the GitHub Actions workflow was not copying it there. This change ensures the binary is built and copied to the correct location before the Docker build step. Signed-off-by: laik <laik.lj@me.com>
tiagolobocastro
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you consider using the distributed CSI node-plugin approach rather than a custom service?
Could you please add the xfs_quota fix as a separate commit?
| @@ -0,0 +1,260 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| #!/bin/bash | |
| #!/use/bin/env bash |
|
The image build seems to be failing, could you please take a look? |
yeah , Let me look at this issue.
What model does distributed CSI refer to? |
Signed-off-by: laik <laik.lj@me.com>
Node deployment (--node-deployment): https://github.com/kubernetes-csi/external-provisioner?tab=readme-ov-file#distributed-provisioning This is the same model used by rawfile-localpv. |
OK, I took a look, this model will be better and can reduce the complexity of network calls, waiting for my testing and next submission. thanks a lot for the reminder |
Title: Introduce PVC Manager for High-Performance LocalPV Provisioning
Description:
This PR introduces a new architecture for the OpenEBS Dynamic LocalPV Provisioner, addressing performance bottlenecks identified during stress testing (see openebs/openebs#4050). The core change replaces the traditional helper pod mechanism with a DaemonSet-based PVC Manager service that performs volume operations via direct HTTP API calls.
Key Changes:
New PVC Manager Component:
cmd/pvc-manager/) which runs as a DaemonSet on each node.Provisioner Integration:
cmd/provisioner-localpv/) is updated to conditionally use the new PVC Manager.OPENEBS_IO_ENABLE_PVC_MANAGER(defaulttrue) andOPENEBS_IO_PVC_MANAGER_PORT(default8080) control this behavior.Deployment Updates:
Benefits:
This new architecture provides a substantial performance improvement for LocalPV provisioning, directly addressing the concerns raised in issue #4050. Backward compatibility with the helper pod mode is maintained via the
OPENEBS_IO_ENABLE_PVC_MANAGERenvironment variable.