Skip to content

Commit 76e400f

Browse files
refactor: Replace of injectIntl with useIntl (#1540)
1 parent 5bd6926 commit 76e400f

File tree

6 files changed

+75
-89
lines changed

6 files changed

+75
-89
lines changed

src/recommendations/tests/RecommendationsList.test.jsx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,12 @@
1-
import React from 'react';
21
import { Provider } from 'react-redux';
32

4-
import { injectIntl, IntlProvider } from '@edx/frontend-platform/i18n';
3+
import { IntlProvider } from '@edx/frontend-platform/i18n';
54
import { render } from '@testing-library/react';
65
import configureStore from 'redux-mock-store';
76

87
import mockedProductData from './mockedData';
98
import RecommendationList from '../RecommendationsList';
109

11-
const IntlRecommendationList = injectIntl(RecommendationList);
1210
const mockStore = configureStore();
1311

1412
describe('RecommendationsListTests', () => {
@@ -25,7 +23,7 @@ describe('RecommendationsListTests', () => {
2523
userId: 1234567,
2624
};
2725

28-
const { container } = render(reduxWrapper(<IntlRecommendationList {...props} />));
26+
const { container } = render(reduxWrapper(<RecommendationList {...props} />));
2927

3028
const recommendationCards = container.querySelectorAll('.recommendation-card');
3129
expect(recommendationCards.length).toEqual(mockedProductData.length);
@@ -37,7 +35,7 @@ describe('RecommendationsListTests', () => {
3735
userId: 1234567,
3836
};
3937

40-
const { getByText } = render(reduxWrapper(<IntlRecommendationList {...props} />));
38+
const { getByText } = render(reduxWrapper(<RecommendationList {...props} />));
4139

4240
const firstFooterContent = getByText('1 Course');
4341
const secondFooterContent = getByText('2 Courses');

src/recommendations/tests/RecommendationsPage.test.jsx

Lines changed: 9 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,8 @@
1-
import React from 'react';
21
import { Provider } from 'react-redux';
32

43
import { getConfig } from '@edx/frontend-platform';
54
import { sendTrackEvent } from '@edx/frontend-platform/analytics';
6-
import { injectIntl, IntlProvider } from '@edx/frontend-platform/i18n';
5+
import { IntlProvider } from '@edx/frontend-platform/i18n';
76
import { useMediaQuery } from '@openedx/paragon';
87
import { fireEvent, render } from '@testing-library/react';
98
import { useLocation } from 'react-router-dom';
@@ -16,7 +15,6 @@ import mockedRecommendedProducts from '../data/tests/mockedData';
1615
import RecommendationsPage from '../RecommendationsPage';
1716
import { eventNames, getProductMapping } from '../track';
1817

19-
const IntlRecommendationsPage = injectIntl(RecommendationsPage);
2018
const mockStore = configureStore();
2119

2220
jest.mock('@edx/frontend-platform/analytics', () => ({
@@ -77,7 +75,7 @@ describe('RecommendationsPageTests', () => {
7775
});
7876

7977
it('should redirect to dashboard if user is not coming from registration workflow', () => {
80-
render(reduxWrapper(<IntlRecommendationsPage />));
78+
render(reduxWrapper(<RecommendationsPage />));
8179
expect(window.location.href).toEqual(dashboardUrl);
8280
});
8381

@@ -86,14 +84,14 @@ describe('RecommendationsPageTests', () => {
8684
recommendations: [],
8785
isLoading: false,
8886
});
89-
render(reduxWrapper(<IntlRecommendationsPage />));
87+
render(reduxWrapper(<RecommendationsPage />));
9088
expect(window.location.href).toEqual(dashboardUrl);
9189
});
9290

9391
it('should redirect user if they click "Skip for now" button', () => {
9492
mockUseLocation();
9593
jest.useFakeTimers();
96-
const { container } = render(reduxWrapper(<IntlRecommendationsPage />));
94+
const { container } = render(reduxWrapper(<RecommendationsPage />));
9795
const skipButton = container.querySelector('.pgn__stateful-btn-state-default');
9896
fireEvent.click(skipButton);
9997
jest.advanceTimersByTime(300);
@@ -103,7 +101,7 @@ describe('RecommendationsPageTests', () => {
103101
it('should display recommendations small layout for small screen', () => {
104102
mockUseLocation();
105103
useMediaQuery.mockReturnValue(true);
106-
const { container } = render(reduxWrapper(<IntlRecommendationsPage />));
104+
const { container } = render(reduxWrapper(<RecommendationsPage />));
107105

108106
const recommendationsSmallLayout = container.querySelector('#recommendations-small-layout');
109107
const reactLoadingSkeleton = container.querySelector('.react-loading-skeleton');
@@ -115,7 +113,7 @@ describe('RecommendationsPageTests', () => {
115113
it('should display recommendations large layout for large screen', () => {
116114
mockUseLocation();
117115
useMediaQuery.mockReturnValue(false);
118-
const { container } = render(reduxWrapper(<IntlRecommendationsPage />));
116+
const { container } = render(reduxWrapper(<RecommendationsPage />));
119117

120118
const pgnCollapsible = container.querySelector('.pgn_collapsible');
121119
const reactLoadingSkeleton = container.querySelector('.react-loading-skeleton');
@@ -131,7 +129,7 @@ describe('RecommendationsPageTests', () => {
131129
recommendations: [],
132130
isLoading: true,
133131
});
134-
const { container } = render(reduxWrapper(<IntlRecommendationsPage />));
132+
const { container } = render(reduxWrapper(<RecommendationsPage />));
135133

136134
const reactLoadingSkeleton = container.querySelector('.react-loading-skeleton');
137135

@@ -145,7 +143,7 @@ describe('RecommendationsPageTests', () => {
145143
recommendations: [],
146144
isLoading: true,
147145
});
148-
const { container } = render(reduxWrapper(<IntlRecommendationsPage />));
146+
const { container } = render(reduxWrapper(<RecommendationsPage />));
149147

150148
const reactLoadingSkeleton = container.querySelector('.react-loading-skeleton');
151149

@@ -160,7 +158,7 @@ describe('RecommendationsPageTests', () => {
160158
});
161159

162160
useMediaQuery.mockReturnValue(false);
163-
render(reduxWrapper(<IntlRecommendationsPage />));
161+
render(reduxWrapper(<RecommendationsPage />));
164162

165163
expect(sendTrackEvent).toBeCalled();
166164
expect(sendTrackEvent).toHaveBeenCalledWith(

0 commit comments

Comments
 (0)