Rename leaveLobby to gameStop and remove non-essential comments

- Renamed property from leaveLobby to gameStop to minimize diff from original
- Removed verbose comments to keep only essential ones
- Maintains same functionality with cleaner code

Co-authored-by: Foorack <5008081+Foorack@users.noreply.github.com>

Author: Copilot

src/client/ClientGameRunner.ts

@@ -78,7 +78,6 @@ export function joinLobby(
 
   const transport = new Transport(lobbyConfig, eventBus);
 
-  // Track the current game runner locally within this closure
   let currentGameRunner: ClientGameRunner | null = null;
 
   const onconnect = () => {
@@ -134,14 +133,13 @@ export function joinLobby(
   };
   transport.connect(onconnect, onmessage);
   return () => {
-    // Check if we should prevent closing (player is still alive in game)
     if (currentGameRunner && currentGameRunner.shouldPreventWindowClose()) {
-      return false; // Don't close, return false to indicate prevented
+      return false;
     }
     console.log("leaving game");
     currentGameRunner = null;
     transport.leaveGame();
-    return true; // Successfully closed, return true
+    return true;
   };
 }
 

src/client/Main.ts

@@ -80,7 +80,7 @@ export interface JoinLobbyEvent {
 }
 
 class Client {
-  private leaveLobby: (() => boolean) | null = null;
+  private gameStop: (() => boolean) | null = null;
   private eventBus: EventBus = new EventBus();
 
   private usernameInput: UsernameInput | null = null;
@@ -154,13 +154,10 @@ class Client {
     this.publicLobby = document.querySelector("public-lobby") as PublicLobby;
 
     window.addEventListener("beforeunload", (e) => {
-      // Try to leave the lobby/game
-      if (this.leaveLobby && !this.leaveLobby()) {
-        // If leaveLobby returns false, it means we should prevent unload
+      if (this.gameStop && !this.gameStop()) {
         e.preventDefault();
         return "";
       }
-      // Successfully closed or no game running
       console.log("Browser is closing");
     });
 
@@ -381,7 +378,7 @@ class Client {
     const onHashUpdate = () => {
       // Reset the UI to its initial state
       this.joinModal.close();
-      if (this.leaveLobby !== null) {
+      if (this.gameStop !== null) {
         this.handleLeaveLobby();
       }
 
@@ -502,13 +499,13 @@ class Client {
   private async handleJoinLobby(event: CustomEvent<JoinLobbyEvent>) {
     const lobby = event.detail;
     console.log(`joining lobby ${lobby.gameID}`);
-    if (this.leaveLobby !== null) {
+    if (this.gameStop !== null) {
       console.log("joining lobby, stopping existing game");
-      this.leaveLobby();
+      this.gameStop();
     }
     const config = await getServerConfigFromClient();
 
-    this.leaveLobby = joinLobby(
+    this.gameStop = joinLobby(
       this.eventBus,
       {
         gameID: lobby.gameID,
@@ -594,12 +591,12 @@ class Client {
   }
 
   private async handleLeaveLobby(/* event: CustomEvent */) {
-    if (this.leaveLobby === null) {
+    if (this.gameStop === null) {
       return;
     }
     console.log("leaving lobby, cancelling game");
-    this.leaveLobby();
-    this.leaveLobby = null;
+    this.gameStop();
+    this.gameStop = null;
     this.publicLobby.leaveLobby();
   }