-
Notifications
You must be signed in to change notification settings - Fork 552
8372530: Easier placement of windows with positioning anchor #1986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mstr2
wants to merge
10
commits into
openjdk:master
Choose a base branch
from
mstr2:feature/stage-anchor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,205
−36
Draft
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
a386784
Implementation of positioning anchor for Stage
mstr2 3789271
refactor Anchor -> AnchorPoint
mstr2 d445623
update tests
mstr2 1e4149e
add clampPolicy and screenPadding
mstr2 6cf52e9
ensure screenPadding is not negative
mstr2 141c188
javadocs
mstr2 d0a56ec
refactor everything
mstr2 5ca15d3
tweaks
mstr2 007d485
doc fixes
mstr2 8d9138b
small changes
mstr2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1117,6 +1117,9 @@ public final ObjectProperty<EventHandler<WindowEvent>> onHiddenProperty() { | |
| 0, 0); | ||
| } | ||
|
|
||
| // Give subclasses a chance to adjust the window bounds | ||
|
||
| fixBounds(); | ||
|
|
||
| // set peer bounds before the window is shown | ||
| applyBounds(); | ||
|
|
||
|
|
@@ -1363,6 +1366,8 @@ private void focusChanged(final boolean newIsFocused) { | |
| } | ||
| } | ||
|
|
||
| void fixBounds() {} | ||
|
|
||
| final void applyBounds() { | ||
| peerBoundsConfigurator.apply(); | ||
| } | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could be a record too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it could, but I don't like the boolean parameter that it would expose. Boolean parameters are usually not a good idea, as they lead to "boolean blindness" at the call site. I've moved this entire class to
javafx.geometry, as it might be useful for other code in the future, and I don't want to proliferate two nested versions of an anchor point (one inStage, the other inPopupWindow).