Commit 78d2197
Improve error handling in Writable stream (#1035)
* Improve error handling in Writable stream
Ensure errors are correctly handled in the Writable stream write.
Previously this would throw an unhandled exception if the response stream had closed (eg, connection had been terminated). This is handled correctly if Node.js 24 stream behaviour is used, but not Node.js 22 or earlier.
Returning the callback with the error ensures consistent behaviour for all Node.js versions (or compat versions)
* Fix typing
* Fix typings again!
* Improve error handling in Writable stream
Enhance error handling specifically for cloudflare node converters.
---------
Co-authored-by: conico974 <nicodorseuil@yahoo.fr>1 parent 18a8f3a commit 78d2197
File tree
2 files changed
+10
-1
lines changed- .changeset
- packages/open-next/src/overrides/wrappers
2 files changed
+10
-1
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
83 | 83 | | |
84 | 84 | | |
85 | 85 | | |
86 | | - | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
87 | 91 | | |
88 | 92 | | |
89 | 93 | | |
| |||
0 commit comments