Fix RemoveUnusedLocalVariables to preserve assignments with side effects in try blocks #741
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cts in try blocks The recipe was incorrectly removing variable assignments in try blocks even when those assignments could throw exceptions and change program behavior. This fix ensures that method invocations within try blocks are preserved since they may throw exceptions that affect control flow. Fixes #740 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
assignmentsMightSideEffect()to check if assignments could have side effectsexpressionMightThrowException()to specifically detect method calls that might throwisAssignmentInTryBlock()to identify assignments within try block scopeTest plan
doNotRemoveVariableAssignmentWithPotentialSideEffectsfor the reported issueRemoveUnusedLocalVariablesTesttests passhandleVariablesReadWithinTrytest still works correctly🤖 Generated with Claude Code