Skip to content

HYPERFLEET-869 - feat: update e2e repository to new sentinel config schema#67

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift-hyperfleet:mainfrom
rh-amarin:update-config
Apr 7, 2026
Merged

HYPERFLEET-869 - feat: update e2e repository to new sentinel config schema#67
openshift-merge-bot[bot] merged 1 commit intoopenshift-hyperfleet:mainfrom
rh-amarin:update-config

Conversation

@rh-amarin
Copy link
Copy Markdown
Contributor

@rh-amarin rh-amarin commented Mar 31, 2026 •
edited by coderabbitai Bot
Loading

https://redhat.atlassian.net/browse/HYPERFLEET-869

Updates the sentinel deployment script to use the new config.clients.hyperfleetApi.baseUrl
Helm value path introduced by HYPERFLEET-549, replacing the old config.hyperfleetApi.baseUrl

Context

HYPERFLEET-549 adopted the HyperFleet Configuration Standard in the Sentinel service, which
restructured the config schema — moving hyperfleetApi under a clients grouping. HYPERFLEET-866
aligned the infra Helm chart default values accordingly. This PR keeps the e2e deploy scripts in
sync with that change.

Test plan

  • Deploy Sentinel (clusters and nodepools) using the updated script in an E2E environment
  • Confirm Sentinel pods reach healthy state and communicate with the HyperFleet API
  • Run a tier0 E2E test suite to verify no regressions

Summary by CodeRabbit

  • Chores
    • Updated deployment configuration to move API and broker settings under client-specific config keys so installer uses the new configuration structure.
    • Minor installer script formatting and parsing tweaks to improve robustness of adapter discovery and installation output.

@openshift-ci openshift-ci Bot requested review from ciaranRoche and mbrudnoy March 31, 2026 19:45
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 31, 2026 •
edited
Loading

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3f1d9334-a2b9-4ab0-96d0-99f5e3e5f96e

📥 Commits

Reviewing files that changed from the base of the PR and between c515953 and f2f332a.

📒 Files selected for processing (2)
  • deploy-scripts/lib/adapter.sh
  • deploy-scripts/lib/sentinel.sh
🚧 Files skipped from review as they are similar to previous changes (1)
  • deploy-scripts/lib/sentinel.sh

Walkthrough

Helm chart configuration keys were adjusted in deployment scripts. In deploy-scripts/lib/sentinel.sh, API and broker settings were moved from config.hyperfleetApi.baseUrl and top-level broker.* to config.clients.hyperfleetApi.baseUrl and config.clients.broker.* respectively, and the dry-run log was updated. In deploy-scripts/lib/adapter.sh, Google Pub/Sub broker.googlepubsub.* keys were moved to config.clients.broker.googlepubsub.*, minor here-string/IFS formatting tweaks and whitespace cleanup were applied. No functional control-flow changes were introduced.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 44.44% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: updating e2e repository scripts to align with the new sentinel config schema by moving config paths under clients grouping.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

rafabene
rafabene reviewed Apr 2, 2026
View reviewed changes
Comment thread deploy-scripts/lib/sentinel.sh Outdated
@rafabene
Copy link
Copy Markdown
Contributor

rafabene commented Apr 7, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm label Apr 7, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 7, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rafabene

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved label Apr 7, 2026
@openshift-merge-bot openshift-merge-bot Bot merged commit 6b60cab into openshift-hyperfleet:main Apr 7, 2026
5 checks passed
@86254860
Copy link
Copy Markdown
Contributor

86254860 commented Apr 8, 2026

/cherry-pick release-0.2

@openshift-cherrypick-robot
Copy link
Copy Markdown

openshift-cherrypick-robot commented Apr 8, 2026

@86254860: new pull request created: #73

Details

In response to this:

/cherry-pick release-0.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rafabene rafabene rafabene left review comments

@ciaranRoche ciaranRoche Awaiting requested review from ciaranRoche

@mbrudnoy mbrudnoy Awaiting requested review from mbrudnoy

Assignees

@rafabene rafabene

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@rh-amarin @rafabene @86254860 @openshift-cherrypick-robot