From 54e7ea2682b2b381b38dcb11fc524679c0a1611c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Tom=C3=A1=C5=A1=20Reme=C5=A1?= Date: Tue, 16 Dec 2025 11:59:52 +0100 Subject: [PATCH] fix: reuse existing handler to set alerts table data --- .../components/Incidents/IncidentsPage.tsx | 31 ++++++++----------- 1 file changed, 13 insertions(+), 18 deletions(-) diff --git a/web/src/components/Incidents/IncidentsPage.tsx b/web/src/components/Incidents/IncidentsPage.tsx index c8557b24e..75f0fb231 100644 --- a/web/src/components/Incidents/IncidentsPage.tsx +++ b/web/src/components/Incidents/IncidentsPage.tsx @@ -131,9 +131,6 @@ const IncidentsPage = () => { (state: MonitoringState) => state.plugins.mcp.incidentsData.incidentsActiveFilters, ); - const alertsData = useSelector( - (state: MonitoringState) => state.plugins.mcp.incidentsData?.alertsData, - ); const alertsAreLoading = useSelector( (state: MonitoringState) => state.plugins.mcp.incidentsData?.alertsAreLoading, ); @@ -239,15 +236,23 @@ const IncidentsPage = () => { ) .then((results) => { const prometheusResults = results.flat(); + const alerts = convertToAlerts( + prometheusResults, + incidentForAlertProcessing, + currentTime, + ); dispatch( setAlertsData({ - alertsData: convertToAlerts( - prometheusResults, - incidentForAlertProcessing, - currentTime, - ), + alertsData: alerts, }), ); + if (rules && alerts) { + dispatch( + setAlertsTableData({ + alertsTableData: groupAlertsForTable(alerts, rules), + }), + ); + } if (!isEmpty(filteredData)) { dispatch(setAlertsAreLoading({ alertsAreLoading: false })); } else { @@ -261,16 +266,6 @@ const IncidentsPage = () => { })(); }, [incidentForAlertProcessing]); - useEffect(() => { - if (rules && alertsData) { - dispatch( - setAlertsTableData({ - alertsTableData: groupAlertsForTable(alertsData, rules), - }), - ); - } - }, [alertsData, rules]); - useEffect(() => { if (!isInitialized) return;