Fix getSign() (#549)

* [WIP] Fix getSign()

* Fix getSign() and add a test case

Author: kio-watanabe

libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/data/CobolNumericField.java

@@ -475,11 +475,7 @@ public int getSign() {
         if (attr.isFlagSignSeparate()) {
             return value == 0x2b ? 1 : -1;
         } else {
-            if (0x30 <= value && value <= 0x39) {
-                return 1;
-            }
-            if (value == 0x20) {
-                this.getDataStorage().setByte(p, (byte) 0x30);
+            if (value == 0x20 || (0x30 <= value && value <= 0x39)) {
                 return 1;
             }
 

tests/Makefile.am

@@ -223,7 +223,8 @@ misc_DEPENDENCIES = \
 	misc.src/file-handler-japanese.at \
 	misc.src/perform-until-div.at \
 	misc.src/search-occurs-depending.at \
-	misc.src/fix-subtract.at
+	misc.src/fix-subtract.at \
+	misc.src/display-numeric-NUMERIC-class.at
 
 EXTRA_DIST = $(srcdir)/package.m4 \
 	$(TESTS) \

tests/Makefile.in

@@ -762,7 +762,8 @@ misc_DEPENDENCIES = \
 	misc.src/file-handler-japanese.at \
 	misc.src/perform-until-div.at \
 	misc.src/search-occurs-depending.at \
-	misc.src/fix-subtract.at
+	misc.src/fix-subtract.at \
+	misc.src/display-numeric-NUMERIC-class.at
 
 EXTRA_DIST = $(srcdir)/package.m4 \
 	$(TESTS) \

tests/misc.at

@@ -53,3 +53,4 @@ m4_include([file-handler-japanese.at])
 m4_include([perform-until-div.at])
 m4_include([search-occurs-depending.at])
 m4_include([fix-subtract.at])
+m4_include([display-numeric-NUMERIC-class.at])

tests/misc.src/display-numeric-NUMERIC-class.at

@@ -0,0 +1,32 @@
+AT_SETUP([DISPLAY numeric after NUMERIC class testing])
+
+AT_DATA([prog.cbl], [
+       IDENTIFICATION   DIVISION.
+       PROGRAM-ID.      prog.
+       DATA             DIVISION.
+       WORKING-STORAGE SECTION.
+       01  N-REC.
+           03  N-VAL PIC 9.
+       PROCEDURE DIVISION.
+       MAIN-PROC.
+      *************************************************************
+           MOVE SPACE TO N-REC.
+           DISPLAY "N-VAL: '" N-VAL "'".
+           
+           IF N-VAL NUMERIC
+               DISPLAY "N-VAL is numeric"
+           ELSE
+               DISPLAY "N-VAL is not numeric"
+           END-IF.
+
+           DISPLAY "N-VAL: '" N-VAL "'".
+])
+
+AT_CHECK([${COBJ} prog.cbl])
+AT_CHECK([java prog], [0], 
+[N-VAL: ' ' 
+N-VAL is not numeric
+N-VAL: ' ' 
+])
+
+AT_CLEANUP