Add missing tags to []conditions which got reported by crd checker

stuggi · stuggi · commit 8d4a59187f29 · 2024-12-03T13:42:54.000+01:00
Adds the task which got reported by the crd checker recently added as a pre-commit validation. In a follow up, we should integrate the new ObservedGeneration for a condition [1]. The observedGeneration represents the .metadata.generation that the condition was set based upon. [1] https://github.com/kubernetes/apimachinery/blob/release-1.29/pkg/apis/meta/v1/types.go#L1518 Signed-off-by: Martin Schuppert <mschuppert@redhat.com>
diff --git a/modules/common/condition/types.go b/modules/common/condition/types.go
@@ -76,6 +76,10 @@ type Condition struct {
 }
 
 // Conditions provide observations of the operational state of a API resource.
+// +patchMergeKey=type
+// +patchStrategy=merge
+// +listType=map
+// +listMapKey=type
 type Conditions []Condition
 
 // conditionGroup defines a group of conditions with the same status and severity,

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,10 @@ type Condition struct {`
`76`	`76`	`}`
`77`	`77`
`78`	`78`	`// Conditions provide observations of the operational state of a API resource.`
	`79`	`+// +patchMergeKey=type`
	`80`	`+// +patchStrategy=merge`
	`81`	`+// +listType=map`
	`82`	`+// +listMapKey=type`
`79`	`83`	`type Conditions []Condition`
`80`	`84`
`81`	`85`	`// conditionGroup defines a group of conditions with the same status and severity,`