Feature faker seed #2180
Feature faker seed #2180
Conversation
Noyabronok
force-pushed
the
feature-faker-seed
branch
from
405fcfc to
706fad3
Compare
|
Looks like failing tests |
Noyabronok
force-pushed
the
feature-faker-seed
branch
from
706fad3 to
f6fa89f
Compare
should be fixed now |
|
Your changes are in MSW package only? I would have expected some changes in the faker package too? |
From what I can tell, the faker folder doesn't contain any faker imports. |
|
OK yeah i don't use faker i just thought it was odd it was an MSW only change :) cc @soartec-lab thoughts? |
There was a problem hiding this comment.
@Noyabronok
Thanks for the great improvements. I left some comments.
| const server = setupServer(); | ||
| server.use(...getPetsMock()); | ||
| ``` | ||
|
|
There was a problem hiding this comment.
We need documentation for the property in the reference too.
| isAllowSyntheticDefaultImports, | ||
| ); | ||
|
|
||
| const seed = options?.seed; |
There was a problem hiding this comment.
I think faker's concerns should be grouped in faker-related files like faker/getters.
|
@Noyabronok |
3 participants
Status
READY
Description
Fix #2175
Adding an option to pass a seed to faker ensures we always get reproducible output.
Todos
Steps to Test
testsfolder runyarn generate:mockfakers.seed(...)calls right after imports intests/generated/mock/project files with a seed defined in themock.config.tsfile