From 5116edb789ddf7a7f31265f5747928fdb9b8353b Mon Sep 17 00:00:00 2001 From: christopherjohnson Date: Wed, 18 Feb 2026 08:41:42 +0000 Subject: [PATCH 1/6] AB#113906 allow get assignment options to have string assignmentId --- .../requestOptions/GetSingleAssignmentOptions.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java index e879c88e..1aa20595 100644 --- a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java +++ b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java @@ -5,7 +5,7 @@ public class GetSingleAssignmentOptions extends BaseOptions { private String courseId; - private Integer assignmentId; + private String assignmentId; public enum Include { SUBMISSION, ASSIGNMENT_VISIBILITY, OVERRIDES, OBSERVED_USERS; @@ -16,7 +16,7 @@ public String toString() { } } - public GetSingleAssignmentOptions(String courseId, Integer assignmentId) { + public GetSingleAssignmentOptions(String courseId, String assignmentId) { if(courseId == null || assignmentId == null) { throw new IllegalArgumentException("Course and assignment IDs are required"); } @@ -24,11 +24,15 @@ public GetSingleAssignmentOptions(String courseId, Integer assignmentId) { this.assignmentId = assignmentId; } + public GetSingleAssignmentOptions(String courseId, Integer assignmentId) { + this(courseId, String.valueOf(assignmentId)); + } + public String getCourseId() { return courseId; } - public Integer getAssignmentId() { + public String getAssignmentId() { return assignmentId; } From cff3f04f3add485191b8c299a47f111efb953831 Mon Sep 17 00:00:00 2001 From: sebastianchristopher <40264653+sebastianchristopher@users.noreply.github.com> Date: Wed, 18 Feb 2026 10:41:32 +0000 Subject: [PATCH 2/6] Update src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --- .../ksu/canvas/requestOptions/GetSingleAssignmentOptions.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java index 1aa20595..f2abfeeb 100644 --- a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java +++ b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java @@ -25,6 +25,9 @@ public GetSingleAssignmentOptions(String courseId, String assignmentId) { } public GetSingleAssignmentOptions(String courseId, Integer assignmentId) { + if (assignmentId == null) { + throw new IllegalArgumentException("Course and assignment IDs are required"); + } this(courseId, String.valueOf(assignmentId)); } From 2b6c117addde763d147d6e511eb5888361f2b2dc Mon Sep 17 00:00:00 2001 From: christopherjohnson Date: Wed, 18 Feb 2026 11:02:50 +0000 Subject: [PATCH 3/6] AB#113906 allow get assignment options to have string assignmentId * refactor GetSingleAssignmentOptions constructor to use Objects.toString for null-safe assignmentId handling --- .../canvas/requestOptions/GetSingleAssignmentOptions.java | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java index f2abfeeb..f5a227d1 100644 --- a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java +++ b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java @@ -1,6 +1,7 @@ package edu.ksu.canvas.requestOptions; import java.util.List; +import java.util.Objects; public class GetSingleAssignmentOptions extends BaseOptions { @@ -25,10 +26,7 @@ public GetSingleAssignmentOptions(String courseId, String assignmentId) { } public GetSingleAssignmentOptions(String courseId, Integer assignmentId) { - if (assignmentId == null) { - throw new IllegalArgumentException("Course and assignment IDs are required"); - } - this(courseId, String.valueOf(assignmentId)); + this(courseId, Objects.toString(assignmentId, null)); } public String getCourseId() { From 8955cf60f3c2466454a4eb6b3d99b2a9b1b9deee Mon Sep 17 00:00:00 2001 From: christopherjohnson Date: Wed, 18 Feb 2026 13:07:38 +0000 Subject: [PATCH 4/6] Revert "AB#113906 allow get assignment options to have string assignmentId" This reverts commit 2b6c117addde763d147d6e511eb5888361f2b2dc. --- .../canvas/requestOptions/GetSingleAssignmentOptions.java | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java index f5a227d1..f2abfeeb 100644 --- a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java +++ b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java @@ -1,7 +1,6 @@ package edu.ksu.canvas.requestOptions; import java.util.List; -import java.util.Objects; public class GetSingleAssignmentOptions extends BaseOptions { @@ -26,7 +25,10 @@ public GetSingleAssignmentOptions(String courseId, String assignmentId) { } public GetSingleAssignmentOptions(String courseId, Integer assignmentId) { - this(courseId, Objects.toString(assignmentId, null)); + if (assignmentId == null) { + throw new IllegalArgumentException("Course and assignment IDs are required"); + } + this(courseId, String.valueOf(assignmentId)); } public String getCourseId() { From 242d53cf5e3d9ad16c523e336235189f32becd01 Mon Sep 17 00:00:00 2001 From: christopherjohnson Date: Wed, 18 Feb 2026 13:07:41 +0000 Subject: [PATCH 5/6] Revert "Update src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java" This reverts commit cff3f04f3add485191b8c299a47f111efb953831. --- .../ksu/canvas/requestOptions/GetSingleAssignmentOptions.java | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java index f2abfeeb..1aa20595 100644 --- a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java +++ b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java @@ -25,9 +25,6 @@ public GetSingleAssignmentOptions(String courseId, String assignmentId) { } public GetSingleAssignmentOptions(String courseId, Integer assignmentId) { - if (assignmentId == null) { - throw new IllegalArgumentException("Course and assignment IDs are required"); - } this(courseId, String.valueOf(assignmentId)); } From 96347def3b4d0a5a47905daa6807a105cca42d18 Mon Sep 17 00:00:00 2001 From: christopherjohnson Date: Wed, 18 Feb 2026 13:08:33 +0000 Subject: [PATCH 6/6] AB#113906 allow get assignment options to have string assignmentId * refactor GetSingleAssignmentOptions constructor to use Objects.toString for null-safe assignmentId handling --- .../ksu/canvas/requestOptions/GetSingleAssignmentOptions.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java index 1aa20595..f5a227d1 100644 --- a/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java +++ b/src/main/java/edu/ksu/canvas/requestOptions/GetSingleAssignmentOptions.java @@ -1,6 +1,7 @@ package edu.ksu.canvas.requestOptions; import java.util.List; +import java.util.Objects; public class GetSingleAssignmentOptions extends BaseOptions { @@ -25,7 +26,7 @@ public GetSingleAssignmentOptions(String courseId, String assignmentId) { } public GetSingleAssignmentOptions(String courseId, Integer assignmentId) { - this(courseId, String.valueOf(assignmentId)); + this(courseId, Objects.toString(assignmentId, null)); } public String getCourseId() {