Better replacement for dynamic uppercase parts in Implements hook_xy #320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I tested this and this works! |
nlighteneddesign
approved these changes
Oct 28, 2025
Contributor
nlighteneddesign
left a comment
nlighteneddesign
left a comment
There was a problem hiding this comment.
I tested locally with the metatag module and it works as expected
bbrala
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacement of hooks that contain a dynamic part such as FORM_ID or ENTITY_TYPE currently don't work.
The problem is that it explicitly only replaces one section of uppercase characters with a regex, so it will try to match against an explicit ID or TYPE. Adding multiple dynamic sections wouldn't work either because the actual replacement might be just one part.
I suggest replacing the whole thing with a preg_replace() that finds any complete section of uppercase characters.
To Test
Drupal.org issue
There is no issue since this is a bugfix to an existing rule.