Skip to content

Conversation

@gitdallas
Copy link
Contributor

@gitdallas gitdallas commented Oct 4, 2025

Closes #11983

image

@patternfly-build
Copy link
Contributor

patternfly-build commented Oct 4, 2025

Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
@gitdallas gitdallas force-pushed the feat/11983-Progress-disableStatusIcon-flag branch from e86cf84 to 6c5dcc6 Compare October 4, 2025 16:07
)}
{StatusIcon && (
<span className={css(progressStyle.progressStatusIcon)}>
<span className={css(progressStyle.progressStatusIcon)} data-testid="progress-status-icon">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to hard code this test id into the component? I'm not sure what a better way to do it would be, but I don't love this, and the fact that there isn't a better way is probably signaling a lack of a11y on this. Would love @thatblindgeye's thoughts on this.

@gitdallas gitdallas requested review from a team and rebeccaalpert and removed request for a team October 8, 2025 21:38
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to add a demo? Probably want to add a prop comment. Otherwise looks fine to me!

gitdallas and others added 2 commits October 9, 2025 14:20
Signed-off-by: gitdallas <5322142+gitdallas@users.noreply.github.com>
Co-authored-by: Rebecca Alpert <ralpert@redhat.com>
@gitdallas
Copy link
Contributor Author

@rebeccaalpert i replaced a few examples with an interactive one
image

Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Surge doesn't have it for whatever Surge-y reason, but localhost looks great.

Co-authored-by: Eric Olkowski <70952936+thatblindgeye@users.noreply.github.com>
Copy link
Contributor

@thatblindgeye thatblindgeye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mentioned in a Slack convo and just commenting here for future reference, but regarding a potential implementation where a consumer wants no icon + no measure + status colors, we could probably recommend:

  • if the status color isn't critical and is really more visual in nature (e.g. maybe there's no actual error or warning message or anything), then the progress bar itself would probably suffice as a means to convey whatever message is meant to be conveyed (e.g. "This thing is almost full")
  • Otherwise, strongly recommened an icon be used, or at the very least a visible measure value if perhaps helper text is provided that has its own error icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Progress - Option to disable icons for variants

5 participants