Skip to content

New Crowdin translations by GitHub Action #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jwise merged 2 commits into from
Nov 27, 2025
Merged

New Crowdin translations by GitHub Action #246

jwise merged 2 commits into from
Nov 27, 2025

Conversation

@github-actions
Copy link

@github-actions github-actions bot commented May 25, 2025

No description provided.

@jplexer
Copy link

jplexer commented May 26, 2025

Uh oh, realized action pulled tintin.pot into root, probably a config error, let me check tomorrow ^^

@jplexer
Copy link

jplexer commented May 30, 2025

Please close this (without merging) and merge #247

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 70cddf1 to d6404f6 Compare June 8, 2025 00:54
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from a8c1769 to 6d4b270 Compare June 22, 2025 00:54
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 370e683 to 3b8ef5b Compare July 6, 2025 00:55
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 500eb3b to fbb47c7 Compare July 13, 2025 00:57
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 63e2d4d to 9a2522d Compare July 27, 2025 00:58
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from b7363ff to 5601c9e Compare July 28, 2025 07:16
@jwise jwise self-requested a review July 28, 2025 07:19
jwise
jwise approved these changes Jul 28, 2025
View reviewed changes
Copy link

@jwise jwise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray!

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 2b4aad0 to 7b1cc02 Compare August 10, 2025 00:57
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 6ba128b to 3eaecba Compare August 24, 2025 00:53
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from d5a6ee3 to 170a665 Compare September 7, 2025 00:49
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from 03a1194 to ab8aef8 Compare October 5, 2025 00:49
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 68307a7 to 9466f8d Compare October 12, 2025 00:47
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch 2 times, most recently from bccbd35 to a37f884 Compare October 26, 2025 00:50
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 311a0e5 to 52c156d Compare November 2, 2025 00:51
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 197f891 to e9e3a54 Compare November 9, 2025 00:51
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 04db672 to d58aa27 Compare November 16, 2025 00:52
@Mr-Bajs
Copy link

Mr-Bajs commented Nov 18, 2025

Hi, so why no merge?

@jwise
Copy link

jwise commented Nov 18, 2025

As I recall from last time I looked at this, the missing merge was because this would break the build because there isn't a character set mapping for one of the languages added, as I recall. But maybe we should exclude that language and merge the rest?

@Mr-Bajs
Copy link

Mr-Bajs commented Nov 19, 2025

That sounds reasonable.

@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from b6c760d to f87d3e1 Compare November 23, 2025 00:55
@hellcp
Copy link
Member

hellcp commented Nov 23, 2025

Another issue with merging this is that the Language Name property isn't set, so the UI on the watch will not display the language name string

jwise added a commit that referenced this pull request Nov 27, 2025
@jwise
i18n: do not attempt to compile languages without metadata
750d8b5 
Crowdin can generate translations for languages that do not yet have
langmaps.  We would choke on attempting to compile those; avoid that
problem.  (Prep for #246.)

License: GPL-3.0-or-later
Signed-off-by: Joshua Wise <joshua@joshuawise.com>
@jwise
Copy link

jwise commented Nov 27, 2025

#303 should fix the stuff needed to make this go

jwise added a commit that referenced this pull request Nov 27, 2025
@jwise
i18n: do not attempt to compile languages without metadata
8491811 
Crowdin can generate translations for languages that do not yet have
langmaps.  We would choke on attempting to compile those; avoid that
problem.  (Prep for #246.)

License: GPL-3.0-or-later
Signed-off-by: Joshua Wise <joshua@joshuawise.com>
@github-actions github-actions bot force-pushed the l10n_crowdin_action branch from 5159f37 to a73aaa6 Compare November 27, 2025 17:58
@jwise
Copy link

jwise commented Nov 27, 2025

Built it by hand with #303, so this should work!

@jwise jwise merged commit 4aade82 into main Nov 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwise jwise jwise approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jplexer @Mr-Bajs @jwise @hellcp @crowdin-bot