Skip to content

Commit 3d995cd

Browse files
FL4TLiN3claude
andcommitted
fix: make review-definition checklist concrete with domain-neutral violation patterns
Reviewer was passing perstack.toml with file paths, Deliverables sections, internal API names, and implementation details because the checklist was too abstract ("contains only domain constraints"). Add specific flag criteria: - Output locations/structure (where to place results, artifact enumeration) - Internal APIs of specified tools (methods/hooks/functions — derivable) - Named alternatives to reject (implicit from positive specification) - Implementation approach (how vs what) - Code snippets, data schemas, step-by-step procedures All patterns are domain-neutral per Design Principle 3 (Domain Agnosticism). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent df35c2e commit 3d995cd

File tree

1 file changed

+6
-3
lines changed

1 file changed

+6
-3
lines changed

definitions/create-expert/perstack.toml

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -402,9 +402,12 @@ For library/tool names appearing in any instruction:
402402
- Traceable to plan.md's Domain Knowledge (i.e., user-specified)? (✓/✗ per name)
403403
- If not user-specified, flag it — the instruction should describe the capability, not name the tool.
404404
405-
For each non-coordinator instruction:
406-
- Contains only domain constraints the LLM cannot derive on its own? (✓/✗)
407-
- Free of code snippets, JSON schemas, and step-by-step procedures? (✓/✗)
405+
For each non-coordinator instruction, flag (✗) if any of the following appear:
406+
- Output locations or structure — dictates where to place results or enumerates specific artifacts to produce. The instruction should describe what the output must accomplish, not its shape.
407+
- Internal APIs of specified tools — names specific methods, hooks, functions, or parameters of a tool. "Use tool X" is the constraint; how to use its API is derivable.
408+
- Named alternatives to reject — lists tools or approaches NOT to use. Specifying what to use implicitly excludes alternatives.
409+
- Implementation approach — describes how to build something rather than what constraints the result must satisfy.
410+
- Code snippets, data schemas, or step-by-step procedures.
408411
409412
## Verdicts
410413

0 commit comments

Comments
 (0)