Skip to content

Commit 674aaf6

Browse files
committed
ext/pdo_mysql: Remove PHP/Set
This simplifies configuration and uses less custom modules on the expense of always visible configuration variable in the GUI. This variable is also used only in the extension's CMakeLists.txt after checking whether the pdo_mysql extension is enabled or not.
1 parent 1d1849c commit 674aaf6

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

cmake/ext/pdo_mysql/CMakeLists.txt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,6 @@ project(
4444

4545
include(CMakeDependentOption)
4646
include(FeatureSummary)
47-
include(PHP/Set)
4847

4948
option(PHP_EXT_PDO_MYSQL "Enable the pdo_mysql extension")
5049

@@ -63,14 +62,15 @@ cmake_dependent_option(
6362
)
6463

6564
# Driver selection option.
66-
php_set(
67-
PHP_EXT_PDO_MYSQL_DRIVER
68-
CHOICES "mysqlnd" "mysql"
69-
IF PHP_EXT_PDO_MYSQL
70-
DOC
65+
set(
66+
CACHE{PHP_EXT_PDO_MYSQL_DRIVER}
67+
TYPE STRING
68+
HELP
7169
"Select MySQL driver: mysqlnd (MySQL Native Driver, recommended) or mysql "
7270
"(system MySQL)"
71+
VALUE "mysqlnd"
7372
)
73+
set_property(CACHE PHP_EXT_PDO_MYSQL_DRIVER PROPERTY STRINGS "mysqlnd" "mysql")
7474
mark_as_advanced(PHP_EXT_PDO_MYSQL_DRIVER)
7575

7676
if(NOT PHP_EXT_PDO_MYSQL)

0 commit comments

Comments
 (0)