-
Notifications
You must be signed in to change notification settings - Fork 14
feat: demo rename slugs #328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx affected -t lint typecheck test --parallel -... |
❌ Failed | 16s | View ↗ |
☁️ Nx Cloud last updated this comment at 2025-11-11 14:44:52 UTC
| .step( | ||
| { slug: 'summarize', dependsOn: ['fetch_article'], baseDelay: 1 }, | ||
| { slug: 'summarize', dependsOn: ['fetchArticle'], baseDelay: 1 }, | ||
| async (input, context) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'attemptNumber' variable is declared but never used. To fix this, either use the variable or prefix it with an underscore to indicate it's intentionally unused: '_attemptNumber'.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| // } | ||
|
|
||
| return summarizeArticle(input.fetch_article.content); | ||
| return 'DEBUG ARTICLE CONTENT'; //summarizeArticle(input.fetchArticle.content); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'input' parameter is used but its properties are not accessed. If the input parameter is required by the function signature but not used, prefix it with an underscore: '_input'.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| }) | ||
| .step({ slug: 'publish', dependsOn: ['summarize', 'extract_keywords'] }, async (input) => { | ||
| await sleep(1000); | ||
| .step({ slug: 'publish', dependsOn: ['summarize', 'extractKeywords'] }, async (input) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'input' parameter is declared but not used in the function. Prefix it with an underscore to indicate it's intentionally unused: '_input'.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| import { extractKeywords } from './tasks/extract-keywords.ts'; | ||
| // import { summarizeArticle } from './tasks/summarize-article.ts'; | ||
| // import { extractKeywords } from './tasks/extract-keywords.ts'; | ||
| import { publishArticle } from './tasks/publish-article.ts'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 'publishArticle' import is declared but never used in the code. Either use this import or remove it to fix the unused variable warning.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| // import { summarizeArticle } from './tasks/summarize-article.ts'; | ||
| // import { extractKeywords } from './tasks/extract-keywords.ts'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These imports are commented out but the functions are referenced in comments below. Either uncomment and use these imports or remove the references to them in the code.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| // if (attemptNumber === 1) { | ||
| // throw new Error('Simulated failure for retry demo'); | ||
| // } else { | ||
| await sleep(SLEEP_MS); | ||
| // } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commented-out code block contains conditional logic that's partially implemented. Either fully implement this logic or remove the commented code to improve code clarity.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
| // return publishArticle( | ||
| // input.summarize.summary, | ||
| // input.summarize.sentiment, | ||
| // input.extractKeywords.keywords | ||
| // ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commented-out code block contains a function call that's not being used. Either use this code or remove the commented section to improve code clarity.
Spotted by Graphite Agent (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
6a717e7 to
353adf0
Compare
33c05f6 to
285cf2a
Compare
285cf2a to
fb04517
Compare
353adf0 to
e8e2510
Compare
fb04517 to
e03fcc0
Compare
e8e2510 to
3c12065
Compare
e03fcc0 to
be528e2
Compare
3c12065 to
878370a
Compare
be528e2 to
b90bf4f
Compare
878370a to
79ee03a
Compare
Merge activity
|

No description provided.