Skip to content

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Nov 7, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 7, 2025

⚠️ No Changeset found

Latest commit: 79ee03a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

jumski commented Nov 7, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge:queue - adds this PR to the back of the merge queue
  • hotfix:queue - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nx-cloud
Copy link

nx-cloud bot commented Nov 7, 2025

🤖 Nx Cloud AI Fix Eligible

An automatically generated fix could have helped fix failing tasks for this run, but Self-healing CI is disabled for this workspace. Visit workspace settings to enable it and get automatic fixes in future runs.

To disable these notifications, a workspace admin can disable them in workspace settings.


View your CI Pipeline Execution ↗ for commit 79ee03a

Command Status Duration Result
nx affected -t lint typecheck test --parallel -... ❌ Failed 16s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-11 14:44:52 UTC

.step(
{ slug: 'summarize', dependsOn: ['fetch_article'], baseDelay: 1 },
{ slug: 'summarize', dependsOn: ['fetchArticle'], baseDelay: 1 },
async (input, context) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'attemptNumber' variable is declared but never used. To fix this, either use the variable or prefix it with an underscore to indicate it's intentionally unused: '_attemptNumber'.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

// }

return summarizeArticle(input.fetch_article.content);
return 'DEBUG ARTICLE CONTENT'; //summarizeArticle(input.fetchArticle.content);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'input' parameter is used but its properties are not accessed. If the input parameter is required by the function signature but not used, prefix it with an underscore: '_input'.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

})
.step({ slug: 'publish', dependsOn: ['summarize', 'extract_keywords'] }, async (input) => {
await sleep(1000);
.step({ slug: 'publish', dependsOn: ['summarize', 'extractKeywords'] }, async (input) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'input' parameter is declared but not used in the function. Prefix it with an underscore to indicate it's intentionally unused: '_input'.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

import { extractKeywords } from './tasks/extract-keywords.ts';
// import { summarizeArticle } from './tasks/summarize-article.ts';
// import { extractKeywords } from './tasks/extract-keywords.ts';
import { publishArticle } from './tasks/publish-article.ts';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'publishArticle' import is declared but never used in the code. Either use this import or remove it to fix the unused variable warning.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +3 to +4
// import { summarizeArticle } from './tasks/summarize-article.ts';
// import { extractKeywords } from './tasks/extract-keywords.ts';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These imports are commented out but the functions are referenced in comments below. Either uncomment and use these imports or remove the references to them in the code.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +28 to +32
// if (attemptNumber === 1) {
// throw new Error('Simulated failure for retry demo');
// } else {
await sleep(SLEEP_MS);
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented-out code block contains conditional logic that's partially implemented. Either fully implement this logic or remove the commented code to improve code clarity.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

Comment on lines +53 to +57
// return publishArticle(
// input.summarize.summary,
// input.summarize.sentiment,
// input.extractKeywords.keywords
// );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commented-out code block contains a function call that's not being used. Either use this code or remove the commented section to improve code clarity.

Spotted by Graphite Agent (based on CI logs)

Fix in Graphite


Is this helpful? React 👍 or 👎 to let us know.

@jumski jumski force-pushed the feat-demo-improve-modal-copy branch from e03fcc0 to be528e2 Compare November 10, 2025 23:37
@jumski jumski force-pushed the feat-demo-rename-slugs branch from 3c12065 to 878370a Compare November 10, 2025 23:37
@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2025

Merge activity

  • Nov 11, 8:50 PM UTC: jumski added this pull request to the Graphite merge queue.
  • Nov 11, 8:53 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #289.
  • Nov 11, 8:54 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #289.
  • Nov 11, 9:05 PM UTC: jumski added this pull request to the Graphite merge queue.
  • Nov 11, 9:06 PM UTC: CI is running for this pull request on a draft pull request (#362) due to your merge queue CI optimization settings.
  • Nov 11, 9:07 PM UTC: Merged by the Graphite merge queue via draft PR: #362.

graphite-app bot pushed a commit that referenced this pull request Nov 11, 2025
@graphite-app graphite-app bot closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants