-
Notifications
You must be signed in to change notification settings - Fork 14
fix: improve mobile UI and reduce maxAttempts from 3 to 2 #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve mobile UI and reduce maxAttempts from 3 to 2 #341
Conversation
|
|
View your CI Pipeline Execution ↗ for commit 556f4a1
☁️ Nx Cloud last updated this comment at |
97a9568 to
cd742df
Compare
a650055 to
e673bd3
Compare
639621a to
0c1e21b
Compare
cd742df to
013d6d0
Compare
013d6d0 to
d93b4fa
Compare
0c1e21b to
556f4a1
Compare
🔍 Preview Deployment: Website✅ Deployment successful! 🔗 Preview URL: https://pr-341.pgflow.pages.dev 📝 Details:
_Last updated: _ |
🔍 Preview Deployment: Demo✅ Deployment successful! 🔗 Preview URL: https://pr-341-pgflow-demo.jumski.workers.dev 📝 Details:
_Last updated: _ |
Merge activity
|
# Improve mobile experience and fix DAG visualization dimming This PR enhances the demo application with several improvements: 1. Fixed DAG visualization dimming behavior: - Added explicit `DAG_STEPS` constant to identify actual DAG steps - Modified dimming logic to only dim nodes when a DAG step is selected (not flow_config) 2. Added responsive mobile detection: - Implemented media query listeners to detect mobile viewports - Added cleanup for event listeners on component destruction 3. Improved JSON truncation for better mobile display: - Reduced truncation length to 50 characters on mobile (vs 500 on desktop) - Applied consistent truncation across EventsPanel and ExplanationPanel 4. Enhanced ExplanationPanel UI: - Improved layout and spacing for better readability - Added bottom padding on mobile to prevent content from being cut off - Refined the orchestration explainer section 5. Updated flow configuration: - Changed `maxAttempts` from 3 to 2 in all relevant files - Added explicit `baseDelay` parameter in the flow definition

Improve mobile experience and fix DAG visualization dimming
This PR enhances the demo application with several improvements:
Fixed DAG visualization dimming behavior:
DAG_STEPSconstant to identify actual DAG stepsAdded responsive mobile detection:
Improved JSON truncation for better mobile display:
Enhanced ExplanationPanel UI:
Updated flow configuration:
maxAttemptsfrom 3 to 2 in all relevant filesbaseDelayparameter in the flow definition