Skip to content

Conversation

@jumski
Copy link
Contributor

@jumski jumski commented Nov 10, 2025

Improve mobile experience and fix DAG visualization dimming

This PR enhances the demo application with several improvements:

  1. Fixed DAG visualization dimming behavior:

    • Added explicit DAG_STEPS constant to identify actual DAG steps
    • Modified dimming logic to only dim nodes when a DAG step is selected (not flow_config)
  2. Added responsive mobile detection:

    • Implemented media query listeners to detect mobile viewports
    • Added cleanup for event listeners on component destruction
  3. Improved JSON truncation for better mobile display:

    • Reduced truncation length to 50 characters on mobile (vs 500 on desktop)
    • Applied consistent truncation across EventsPanel and ExplanationPanel
  4. Enhanced ExplanationPanel UI:

    • Improved layout and spacing for better readability
    • Added bottom padding on mobile to prevent content from being cut off
    • Refined the orchestration explainer section
  5. Updated flow configuration:

    • Changed maxAttempts from 3 to 2 in all relevant files
    • Added explicit baseDelay parameter in the flow definition

@changeset-bot
Copy link

changeset-bot bot commented Nov 10, 2025

⚠️ No Changeset found

Latest commit: 556f4a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor Author

jumski commented Nov 10, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • merge:queue - adds this PR to the back of the merge queue
  • hotfix:queue - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@nx-cloud
Copy link

nx-cloud bot commented Nov 10, 2025

View your CI Pipeline Execution ↗ for commit 556f4a1

Command Status Duration Result
nx affected -t deploy:preview --projects=demo -... ✅ Succeeded 59s View ↗
nx affected -t verify-exports --base=d93b4fa048... ✅ Succeeded <1s View ↗
nx affected -t build --configuration=production... ✅ Succeeded 30s View ↗
nx affected -t lint typecheck test --parallel -... ✅ Succeeded 18s View ↗

☁️ Nx Cloud last updated this comment at 2025-11-11 14:45:20 UTC

@jumski jumski force-pushed the 11-10-feat_demo_-_prepare_final_deployment branch from 97a9568 to cd742df Compare November 10, 2025 20:45
@jumski jumski force-pushed the 11-10-feat_final_tweaks_v2 branch 2 times, most recently from a650055 to e673bd3 Compare November 10, 2025 21:04
@jumski jumski force-pushed the 11-10-feat_final_tweaks_v2 branch 2 times, most recently from 639621a to 0c1e21b Compare November 10, 2025 23:37
@jumski jumski force-pushed the 11-10-feat_demo_-_prepare_final_deployment branch from cd742df to 013d6d0 Compare November 10, 2025 23:37
@jumski jumski force-pushed the 11-10-feat_demo_-_prepare_final_deployment branch from 013d6d0 to d93b4fa Compare November 11, 2025 14:38
@jumski jumski force-pushed the 11-10-feat_final_tweaks_v2 branch from 0c1e21b to 556f4a1 Compare November 11, 2025 14:38
@github-actions
Copy link
Contributor

🔍 Preview Deployment: Website

Deployment successful!

🔗 Preview URL: https://pr-341.pgflow.pages.dev

📝 Details:

  • Branch: 11-10-feat_final_tweaks_v2
  • Commit: 8781f38c28c30dd4d21de5199600485ecf782c7b
  • View Logs

_Last updated: _

@github-actions
Copy link
Contributor

🔍 Preview Deployment: Demo

Deployment successful!

🔗 Preview URL: https://pr-341-pgflow-demo.jumski.workers.dev

📝 Details:

  • Branch: 11-10-feat_final_tweaks_v2
  • Commit: 8781f38c28c30dd4d21de5199600485ecf782c7b
  • View Logs

_Last updated: _

@graphite-app
Copy link
Contributor

graphite-app bot commented Nov 11, 2025

Merge activity

  • Nov 11, 8:50 PM UTC: jumski added this pull request to the Graphite merge queue.
  • Nov 11, 8:53 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #289.
  • Nov 11, 8:54 PM UTC: The Graphite merge queue removed this pull request due to downstack failures on PR #289.
  • Nov 11, 9:05 PM UTC: jumski added this pull request to the Graphite merge queue.
  • Nov 11, 9:06 PM UTC: CI is running for this pull request on a draft pull request (#362) due to your merge queue CI optimization settings.
  • Nov 11, 9:07 PM UTC: Merged by the Graphite merge queue via draft PR: #362.

graphite-app bot pushed a commit that referenced this pull request Nov 11, 2025
# Improve mobile experience and fix DAG visualization dimming

This PR enhances the demo application with several improvements:

1. Fixed DAG visualization dimming behavior:
   - Added explicit `DAG_STEPS` constant to identify actual DAG steps
   - Modified dimming logic to only dim nodes when a DAG step is selected (not flow_config)

2. Added responsive mobile detection:
   - Implemented media query listeners to detect mobile viewports
   - Added cleanup for event listeners on component destruction

3. Improved JSON truncation for better mobile display:
   - Reduced truncation length to 50 characters on mobile (vs 500 on desktop)
   - Applied consistent truncation across EventsPanel and ExplanationPanel

4. Enhanced ExplanationPanel UI:
   - Improved layout and spacing for better readability
   - Added bottom padding on mobile to prevent content from being cut off
   - Refined the orchestration explainer section

5. Updated flow configuration:
   - Changed `maxAttempts` from 3 to 2 in all relevant files
   - Added explicit `baseDelay` parameter in the flow definition
@graphite-app graphite-app bot closed this Nov 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants