Cleanup

Author: dereuromark

PhpCollective/Sniffs/AbstractSniffs/AbstractSniff.php

@@ -21,11 +21,6 @@ abstract class AbstractSniff implements Sniff
 {
     use BasicsTrait;
 
-    /**
-     * @var string
-     */
-    protected const NAMESPACE_SPRYKER = 'Spryker';
-
     /**
      * @var array<string> These markers must remain as inline comments
      */
@@ -59,18 +54,6 @@ protected function isPhpStormMarker(File $phpCsFile, int $stackPtr): bool
         return false;
     }
 
-    /**
-     * @param \PHP_CodeSniffer\Files\File $phpCsFile
-     *
-     * @return bool
-     */
-    protected function isSprykerNamespace(File $phpCsFile): bool
-    {
-        $namespace = $this->getNamespace($phpCsFile);
-
-        return strpos($namespace, static::NAMESPACE_SPRYKER) === 0;
-    }
-
     /**
      * Get level of indentation, 0 based.
      *

PhpCollective/Sniffs/Commenting/DisallowArrayTypeHintSyntaxSniff.php

@@ -75,6 +75,7 @@ public function register(): array
     /**
      * @phpcsSuppress SlevomatCodingStandard.TypeHints.ParameterTypeHint.MissingNativeTypeHint
      *
+     * @param \PHP_CodeSniffer\Files\File $phpcsFile
      * @param int $docCommentOpenPointer
      *
      * @return void
@@ -347,6 +348,8 @@ protected function containsArrayTypeNode(array $types): bool
     }
 
     /**
+     * @param \PHPStan\PhpDocParser\Ast\Node $node
+     *
      * @return list<\PHPStan\PhpDocParser\Ast\Type\ArrayTypeNode>
      */
     public function getArrayTypeNodes(Node $node): array
@@ -362,6 +365,8 @@ public function getArrayTypeNodes(Node $node): array
                 private $nodes = [];
 
                 /**
+                 * @param \PHPStan\PhpDocParser\Ast\Node $node
+                 *
                  * @return \PHPStan\PhpDocParser\Ast\Node|list<\PHPStan\PhpDocParser\Ast\Node>|\PHPStan\PhpDocParser\Ast\NodeTraverser::*|null
                  */
                 public function enterNode(Node $node)
@@ -406,6 +411,11 @@ public function getNodes(): array
         return $visitor->getNodes();
     }
 
+    /**
+     * @param \PHPStan\PhpDocParser\Ast\Type\TypeNode $node
+     *
+     * @return \PHPStan\PhpDocParser\Ast\Type\TypeNode
+     */
     private function fixArrayNode(TypeNode $node): TypeNode
     {
         if (!$node instanceof ArrayTypeNode) {
@@ -416,7 +426,10 @@ private function fixArrayNode(TypeNode $node): TypeNode
     }
 
     /**
+     * @param \PHPStan\PhpDocParser\Ast\Type\ArrayTypeNode $arrayTypeNode
      * @param list<\PHPStan\PhpDocParser\Ast\Type\UnionTypeNode> $unionTypeNodes
+     *
+     * @return \PHPStan\PhpDocParser\Ast\Type\UnionTypeNode|null
      */
     private function findUnionTypeThatContainsArrayType(ArrayTypeNode $arrayTypeNode, array $unionTypeNodes): ?UnionTypeNode
     {
@@ -429,6 +442,14 @@ private function findUnionTypeThatContainsArrayType(ArrayTypeNode $arrayTypeNode
         return null;
     }
 
+    /**
+     * @param \PHP_CodeSniffer\Files\File $phpcsFile
+     * @param int $docCommentOpenPointer
+     * @param \PHPStan\PhpDocParser\Ast\Type\TypeNode $typeNode
+     * @param \PHPStan\PhpDocParser\Ast\PhpDoc\PhpDocTagValueNode $annotationValue
+     *
+     * @return string|null
+     */
     private function findGenericIdentifier(
         File $phpcsFile,
         int $docCommentOpenPointer,
@@ -489,6 +510,11 @@ private function findGenericIdentifier(
         return null;
     }
 
+    /**
+     * @param string $type
+     *
+     * @return bool
+     */
     private function isTraversableType(string $type): bool
     {
         return TypeHintHelper::isSimpleIterableTypeHint($type) || array_key_exists($type, $this->getNormalizedTraversableTypeHints());