Completes AdapterFactoryTest

Resets Psalm baseline
Signed-off-by: Joey Smith <jsmith@webinertia.net>

Signed-off-by: Joey Smith <jsmith@webinertia.net>

Author: tyrsson

psalm-baseline.xml

@@ -36,9 +36,6 @@
     <ClassMustBeFinal>
       <code><![CDATA[Connection]]></code>
     </ClassMustBeFinal>
-    <InvalidArgument>
-      <code><![CDATA[$resultResource === true ? $this->resource : $resultResource]]></code>
-    </InvalidArgument>
     <InvalidReturnStatement>
       <code><![CDATA[$r[0]]]></code>
     </InvalidReturnStatement>
@@ -84,6 +81,9 @@
     <NullableReturnStatement>
       <code><![CDATA[$r[0]]]></code>
     </NullableReturnStatement>
+    <PossiblyInvalidArgument>
+      <code><![CDATA[$resultResource === true ? $this->resource : $resultResource]]></code>
+    </PossiblyInvalidArgument>
     <PossiblyInvalidMethodCall>
       <code><![CDATA[fetch_row]]></code>
     </PossiblyInvalidMethodCall>
@@ -130,11 +130,9 @@
       <code><![CDATA[Mysqli]]></code>
     </ClassMustBeFinal>
     <ImplementedParamTypeMismatch>
+      <code><![CDATA[$resource]]></code>
       <code><![CDATA[$sqlOrResource]]></code>
     </ImplementedParamTypeMismatch>
-    <InvalidArgument>
-      <code><![CDATA[$resource]]></code>
-    </InvalidArgument>
     <InvalidReturnStatement>
       <code><![CDATA[$this->getConnection()->getLastGeneratedValue()]]></code>
     </InvalidReturnStatement>
@@ -151,14 +149,13 @@
       <code><![CDATA[getProfiler]]></code>
       <code><![CDATA[getResultPrototype]]></code>
       <code><![CDATA[getStatementPrototype]]></code>
-      <code><![CDATA[registerConnection]]></code>
     </PossiblyUnusedMethod>
-    <PossiblyUnusedParam>
-      <code><![CDATA[$connection]]></code>
-    </PossiblyUnusedParam>
     <PossiblyUnusedReturnValue>
       <code><![CDATA[bool]]></code>
     </PossiblyUnusedReturnValue>
+    <UndefinedDocblockClass>
+      <code><![CDATA[\mysqli|mysqli_result|mysqli_stmt]]></code>
+    </UndefinedDocblockClass>
     <UnusedVariable>
       <code><![CDATA[$options]]></code>
     </UnusedVariable>
@@ -238,9 +235,6 @@
     <ClassMustBeFinal>
       <code><![CDATA[Statement]]></code>
     </ClassMustBeFinal>
-    <InvalidArgument>
-      <code><![CDATA[$this->resource]]></code>
-    </InvalidArgument>
     <MixedAssignment>
       <code><![CDATA[$args[]]]></code>
       <code><![CDATA[$value]]></code>

test/integration/Container/AdapterFactoryTest.php

@@ -4,14 +4,23 @@
 
 namespace LaminasIntegrationTest\Db\Adapter\Mysql\Container;
 
+use Laminas\Db\Adapter\AdapterInterface;
+use Laminas\Db\Adapter\Mysql\Container\AdapterFactory;
+use LaminasIntegrationTest\Db\Adapter\Mysql\Container\TestAsset\SetupTrait;
+use PHPUnit\Framework\Attributes\CoversClass;
+use PHPUnit\Framework\Attributes\CoversMethod;
 use PHPUnit\Framework\TestCase;
 
+#[CoversClass(AdapterFactory::class)]
+#[CoversMethod(AdapterFactory::class, '__invoke')]
 final class AdapterFactoryTest extends TestCase
 {
+    use SetupTrait;
+
     public function testFactoryReturnsAdapterInterface(): void
     {
-        $this->markTestIncomplete(
-            'This test is incomplete and needs to be implemented.'
-        );
+        $factory = new AdapterFactory();
+        $adapter = $factory($this->container);
+        self::assertInstanceOf(AdapterInterface::class, $adapter);
     }
 }

test/integration/Container/TestAsset/SetupTrait.php

@@ -13,6 +13,7 @@
 use Laminas\Db\Container\ConfigProvider as LaminasDbConfigProvider;
 use Laminas\ServiceManager\ServiceManager;
 use Laminas\Stdlib\ArrayUtils;
+use Psr\Container\ContainerInterface;
 
 use function getenv;
 
@@ -32,6 +33,8 @@ trait SetupTrait
 
     protected AdapterManager $adapterManager;
 
+    protected ContainerInterface $container;
+
     protected DriverInterface|string|null $driver = null;
 
     protected function setUp(): void
@@ -86,8 +89,8 @@ protected function getAdapter(array $config = []): AdapterInterface&Adapter
         );
 
         $this->config         = $serviceManagerConfig;
-        $container            = new ServiceManager($this->config);
-        $this->adapterManager = $container->get(AdapterManager::class);
+        $this->container      = new ServiceManager($this->config);
+        $this->adapterManager = $this->container->get(AdapterManager::class);
         $this->adapter        = $this->adapterManager->get(AdapterInterface::class);
 
         return $this->adapter;