Skip to content

Commit 49a38a5

Browse files
committed
Update the code following static analysis review
This change is a minor one, changing the code, improving it based on the results of the review.
1 parent a117ffc commit 49a38a5

File tree

7 files changed

+23
-7
lines changed

7 files changed

+23
-7
lines changed

src/Driver/Pdo/Pdo.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
use PhpDb\Adapter\Driver\ResultInterface;
1414
use PhpDb\Adapter\Sqlite\Driver\DatabasePlatformNameTrait;
1515

16-
final class Pdo extends AbstractPdo implements DriverFeatureProviderInterface
16+
class Pdo extends AbstractPdo implements DriverFeatureProviderInterface
1717
{
1818
use DatabasePlatformNameTrait;
1919
use DriverFeatureProviderTrait;

src/Platform/Sqlite.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public function quoteValue(string $value): string
4242
$resource = $resource->getConnection()->getResource();
4343
}
4444

45-
if ($resource instanceof PDO) {
45+
if ($resource instanceof \PDO) {
4646
return $resource->quote($value);
4747
}
4848

@@ -61,7 +61,7 @@ public function quoteTrustedValue(int|float|string|bool $value): ?string
6161
$resource = $resource->getConnection()->getResource();
6262
}
6363

64-
if ($resource instanceof PDO) {
64+
if ($resource instanceof \PDO) {
6565
return $resource->quote($value);
6666
}
6767

test/unit/AdapterServiceFactoryTest.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
use Override;
88
use PhpDb\Adapter\Profiler\Profiler;
99
use PhpDb\Adapter\Profiler\ProfilerInterface;
10-
use PhpDb\Adapter\Sqlite\Adapter;
11-
use PhpDb\Adapter\Sqlite\AdapterServiceFactory;
10+
use PhpDb\Adapter\Adapter;
11+
use PhpDb\Adapter\AdapterServiceFactory;
1212
use PhpDb\Adapter\Sqlite\ConfigProvider;
1313
use PHPUnit\Framework\Attributes\CoversMethod;
1414
use PHPUnit\Framework\TestCase;

test/unit/AdapterTest.php

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
use PhpDb\Adapter\AdapterInterface;
88
use PhpDb\Adapter\Driver\ConnectionInterface;
99
use PhpDb\Adapter\Driver\DriverInterface;
10+
use PhpDb\Adapter\Driver\PdoDriverInterface;
1011
use PhpDb\Adapter\Driver\ResultInterface;
1112
use PhpDb\Adapter\Driver\StatementInterface;
1213
use PhpDb\Adapter\ParameterContainer;

test/unit/ConfigProviderTest.php

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,10 @@ public function testProvidesExpectedDependencies(): ConfigProvider
9191
public function testProvidesExpectedAdapterManagerConfiguration(): void
9292
{
9393
$provider = new ConfigProvider();
94-
self::assertEquals($this->adapterManagerConfig, $provider->getAdapterManagerConfig());
94+
self::assertEquals(
95+
$this->adapterManagerConfig,
96+
$provider->getAdapterManagerConfig()
97+
);
9598
}
9699

97100
#[Depends('testProvidesExpectedDependencies')]

test/unit/Driver/Pdo/StatementTest.php

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,11 @@
77
use Override;
88
use PhpDb\Adapter\Driver\Pdo\Statement;
99
use PhpDb\Adapter\ParameterContainer;
10+
use PhpDb\Adapter\Sqlite\Container\PdoDriverFactory;
1011
use PhpDb\Adapter\Sqlite\Driver\Pdo\Connection;
1112
use PHPUnit\Framework\Attributes\CoversMethod;
1213
use PHPUnit\Framework\TestCase;
14+
use Psr\Container\ContainerInterface;
1315

1416
#[CoversMethod(Statement::class, 'setDriver')]
1517
#[CoversMethod(Statement::class, 'setParameterContainer')]
@@ -26,7 +28,14 @@ final class StatementTest extends TestCase
2628

2729
public function testSetDriver(): void
2830
{
29-
self::assertEquals($this->statement, $this->statement->setDriver(new Driver(new Connection())));
31+
self::assertEquals(
32+
$this->statement,
33+
$this->statement->setDriver(
34+
(new PdoDriverFactory())->__invoke(
35+
$this->createMock(ContainerInterface::class)
36+
)
37+
)
38+
);
3039
}
3140

3241
public function testSetParameterContainer(): void

test/unit/Platform/SqliteTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,13 @@
33
namespace PhpDbTest\Adapter\Sqlite\Sqlite\Platform;
44

55
use Override;
6+
use PDO;
7+
use PhpDb\Adapter\Sqlite\Container\PdoDriverFactory;
68
use PhpDb\Adapter\Sqlite\Driver\Pdo\Connection;
79
use PhpDb\Adapter\Sqlite\Platform\Sqlite;
810
use PHPUnit\Framework\Attributes\CoversMethod;
911
use PHPUnit\Framework\TestCase;
12+
use Psr\Container\ContainerInterface;
1013

1114
use function file_exists;
1215
use function restore_error_handler;

0 commit comments

Comments
 (0)