From a739a2df0e84590a5362d27fcef3d38a1d383f5c Mon Sep 17 00:00:00 2001 From: Greg Bowler Date: Fri, 24 Oct 2025 14:23:35 +0100 Subject: [PATCH 1/5] fix: null-safe check of query string key closes #226 --- src/ServerRequest.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/ServerRequest.php b/src/ServerRequest.php index ce51cc9..6c69bbb 100644 --- a/src/ServerRequest.php +++ b/src/ServerRequest.php @@ -93,7 +93,7 @@ public function withCookieParams(array $cookies):self { * @return array> */ public function getQueryParams():array { - parse_str($this->serverData["QUERY_STRING"], $params); + parse_str($this->serverData["QUERY_STRING"] ?? "", $params); /** @var array> $params */ return $params; } From f936826d9ad98b0d275b6ee51b562717c2c086cc Mon Sep 17 00:00:00 2001 From: Greg Bowler Date: Fri, 24 Oct 2025 14:25:26 +0100 Subject: [PATCH 2/5] tweak: remove non-existent test --- phpcs.xml | 1 - 1 file changed, 1 deletion(-) diff --git a/phpcs.xml b/phpcs.xml index 1fa70a0..ecbe2b7 100644 --- a/phpcs.xml +++ b/phpcs.xml @@ -24,7 +24,6 @@ - From f988bb0054618133a2d18e0b5b12d1a0e7020820 Mon Sep 17 00:00:00 2001 From: Greg Bowler Date: Fri, 24 Oct 2025 14:27:32 +0100 Subject: [PATCH 3/5] ci: add codecov token --- .github/workflows/ci.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e1bed71..58de5a4 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -92,6 +92,8 @@ jobs: - name: Upload to Codecov uses: codecov/codecov-action@v5 + with: + token: ${{ secrets.CODECOV_TOKEN }} phpstan: runs-on: ubuntu-latest From 3afbea479507a957d8be75448935ed3752545be1 Mon Sep 17 00:00:00 2001 From: Greg Bowler Date: Fri, 24 Oct 2025 14:29:49 +0100 Subject: [PATCH 4/5] ci: add codecov slug --- .github/workflows/ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 58de5a4..36fc0ff 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -94,6 +94,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} + slug: phpgt/Http phpstan: runs-on: ubuntu-latest From a2a3e8721a090dcf05943c5c40f5a663510e806d Mon Sep 17 00:00:00 2001 From: Greg Bowler Date: Fri, 24 Oct 2025 14:40:33 +0100 Subject: [PATCH 5/5] ci: tweak slug --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 36fc0ff..a4c90ef 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -94,7 +94,7 @@ jobs: uses: codecov/codecov-action@v5 with: token: ${{ secrets.CODECOV_TOKEN }} - slug: phpgt/Http + slug: PhpGt/Http phpstan: runs-on: ubuntu-latest