NodeScopeResolver: Move assignByReference logic out of generic path

Author: staabm

src/Analyser/NodeScopeResolver.php

@@ -5755,7 +5755,6 @@ private function processArgs(
 
 		if ($parameters !== null) {
 			foreach ($args as $i => $arg) {
-				$byRefType = new MixedType();
 				$assignByReference = false;
 				$currentParameter = null;
 				if (isset($parameters[$i])) {
@@ -5766,21 +5765,6 @@ private function processArgs(
 
 				if ($currentParameter !== null) {
 					$assignByReference = $currentParameter->passedByReference()->createsNewVariable();
-					if ($assignByReference) {
-						if ($currentParameter instanceof ExtendedParameterReflection && $currentParameter->getOutType() !== null) {
-							$byRefType = $currentParameter->getOutType();
-						} elseif (
-							$calleeReflection instanceof MethodReflection
-							&& !$calleeReflection->getDeclaringClass()->isBuiltin()
-						) {
-							$byRefType = $currentParameter->getType();
-						} elseif (
-							$calleeReflection instanceof FunctionReflection
-							&& !$calleeReflection->isBuiltin()
-						) {
-							$byRefType = $currentParameter->getType();
-						}
-					}
 				}
 
 				if ($assignByReference) {
@@ -5793,6 +5777,23 @@ private function processArgs(
 						$paramOutType = $this->getParameterOutExtensionsType($callLike, $calleeReflection, $currentParameter, $scope);
 						if ($paramOutType !== null) {
 							$byRefType = $paramOutType;
+						} elseif (
+							$currentParameter instanceof ExtendedParameterReflection
+							&& $currentParameter->getOutType() !== null
+						) {
+							$byRefType = $currentParameter->getOutType();
+						} elseif (
+							$calleeReflection instanceof MethodReflection
+							&& !$calleeReflection->getDeclaringClass()->isBuiltin()
+						) {
+							$byRefType = $currentParameter->getType();
+						} elseif (
+							$calleeReflection instanceof FunctionReflection
+							&& !$calleeReflection->isBuiltin()
+						) {
+							$byRefType = $currentParameter->getType();
+						} else {
+							$byRefType = new MixedType();
 						}
 
 						$scope = $this->processVirtualAssign(