From a946d1af0521468eb8655a16d2effa372abd30b4 Mon Sep 17 00:00:00 2001
From: JiaJia Ji <kingjia90@gmail.com>
Date: Wed, 17 Dec 2025 12:30:30 +0100
Subject: [PATCH] Refactor propertiesAction to avoid duplicate permission check

Removed duplicate permission check for predefined properties.
---
 src/Controller/Admin/SettingsController.php | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/Controller/Admin/SettingsController.php b/src/Controller/Admin/SettingsController.php
index 5d3ea46072..19b2d22491 100644
--- a/src/Controller/Admin/SettingsController.php
+++ b/src/Controller/Admin/SettingsController.php
@@ -261,9 +261,9 @@ public function getPredefinedMetadataAction(Request $request): JsonResponse
      */
     public function propertiesAction(Request $request): JsonResponse
     {
+        $this->checkPermission('predefined_properties');
+        
         if ($request->get('data')) {
-            $this->checkPermission('predefined_properties');
-
             if ($request->get('xaction') == 'destroy') {
                 $data = $this->decodeJson($request->get('data'));
                 $id = $data['id'];