Skip to content

updateDataObject is only partially async #389

@cancan101

Description

@cancan101

updateDataObject makes blocking calls to the (external) search provider.

updateData is async:

$dataObject = $event->getObject();
Service::useInheritedValues(true, fn () =>
$this->indexQueueService
->updateIndexQueue(
$dataObject,
IndexQueueOperation::UPDATE->value,
$this->synchronousProcessing->isEnabled(),
$dataObject->hasChildren(includingUnpublished: true),
$this->synchronousProcessingRelatedIds->isEnabled() === false
)
->commit()
);
$this->queueMessagesDispatcher->dispatchQueueMessages();

but updateSiblings is not:

if ($newIndex === $this->getIndexedIndex($element)

this can cause significant slowdowns with object updates, especially for large folders.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions