Add datachannel whip whep example #3115
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3115 +/- ##
==========================================
+ Coverage 83.99% 84.00% +0.01%
==========================================
Files 80 80
Lines 9041 9041
==========================================
+ Hits 7594 7595 +1
Misses 1025 1025
+ Partials 422 421 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
I give permission to any maintainers to make commits for me btw |
JoeTurki
force-pushed
the
add-datachannel-whip-whep
branch
from
dae2163 to
5832990
Compare
|
@ValorZard I finished your example, added somestuff like random username for users, finished broadcasting, and renamed it like we talked in discord, let me know if it's ready to merge or if there anything you would like to add 🙏 
|
|
We would probably need to change the README since its no longer correct. Otherwise, looks good! |
|
@ValorZard i updated the readme let me know if there anything i missed or if you want to commit anything |
ValorZard
left a comment
ValorZard
left a comment
There was a problem hiding this comment.
Other than checking if a username has already been taken, this seems to look good
JoeTurki
force-pushed
the
add-datachannel-whip-whep
branch
from
abef201 to
c3f42a8
Compare
A data-channel example with whip-whep like pattern. And a simple broadcast system. Co-authored-by: Joe Turki <git@joeturki.com>
JoeTurki
force-pushed
the
add-datachannel-whip-whep
branch
from
c3f42a8 to
8b9583c
Compare
Description
Add datachannel whip whep example
(probably going to add two examples, one js based and one detached pure golang example)