fixed in signin ui when the system apperance in dark mode #2096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR:
This PR fixes the issue where the GitHub icon was not visible in dark mode due to low contrast between the icon and background color.
The fix ensures the GitHub sign-in button is clearly visible and accessible in both dark and light themes by adding adaptive icon color styling.
Fixes #(issue)
Before → After (Dark Mode):
-Before: GitHub icon hidden in dark background.
-After: Icon visible with proper contrast.
Image provided
Type of change
-Bug fix (non-breaking change which fixes an issue)
-New feature (non-breaking change which adds functionality)
-Breaking change (fix or feature that would cause existing functionality to not work as expected)
-This change requires a documentation update
tested
Checklist
I have read the contributing guide