Skip to content

Conversation

@chandan9648
Copy link

@chandan9648 chandan9648 commented Nov 8, 2025

PR:

This PR fixes the issue where the GitHub icon was not visible in dark mode due to low contrast between the icon and background color.
The fix ensures the GitHub sign-in button is clearly visible and accessible in both dark and light themes by adding adaptive icon color styling.

Fixes #(issue)

Before → After (Dark Mode):

-Before: GitHub icon hidden in dark background.
-After: Icon visible with proper contrast.

Image provided

Screenshot 2025-11-08 170720

Type of change

-Bug fix (non-breaking change which fixes an issue)

  • Chore (refactoring code, technical debt, workflow improvements)
    -New feature (non-breaking change which adds functionality)
    -Breaking change (fix or feature that would cause existing functionality to not work as expected)
    -This change requires a documentation update

tested

  1. Switch between light and dark mode.
  2. Go to the Sign in page.
  3. Verify that the GitHub icon is clearly visible in both modes.
  4. Ensure the button layout and theme transitions remain smooth.
  • Test in dark mode
  • Test in light mode

Checklist

I have read the contributing guide

  1. My code follows the style guidelines of this project
  2. I have commented my code where necessary
  3. I have checked if my PR needs documentation updates
  4. I have verified that my changes introduce no new warnings
  5. I have tested that the fix works in both light and dark modes

@vercel
Copy link

vercel bot commented Nov 8, 2025

@chandan9648 is attempting to deploy a commit to the Piyush Garg's projects Team on Vercel.

A member of the Team first needs to authorize it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant