Fix showForm() signature

Author: cedric-anne

inc/mantis.class.php

@@ -68,7 +68,7 @@ static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtem
 
          if (Session::haveRightsOr('plugin_mantis_use', [READ, UPDATE])) {
             $PluginMantisMantis = new self();
-            $PluginMantisMantis->showForm($item);
+            $PluginMantisMantis->showFormForItilItem($item);
          } else {
             echo "<div align='center'><br><br><img src=\"" . $CFG_GLPI["root_doc"] .
                      "/pics/warning.png\" alt=\"warning\"><br><br>";
@@ -479,7 +479,7 @@ private static function getInfoSolved($list_ticket_mantis) {
     *
     * @param $item
     */
-   public function showForm($item) {
+   public function showFormForItilItem($item) {
       global $CFG_GLPI;
 
       $ws = new PluginMantisMantisws();

inc/profile.class.php

@@ -101,35 +101,25 @@ static function displayTabContentForItem(CommonGLPI $item, $tabnum = 1, $withtem
    }
 
 
-   /**
-   * Show profile form
-   *
-   * @param $items_id integer id of the profile
-   * @param $target value url of target
-   *
-   * @return nothing
-   **/
-   function showForm($profiles_id = 0, $openform = true, $closeform = true) {
+   function showForm($ID, array $options = []) {
 
       echo "<div class='firstbloc'>";
-      if (($canedit = Session::haveRightsOr(self::$rightname, [CREATE, UPDATE, PURGE]))
-          && $openform) {
+      if ($canedit = Session::haveRightsOr(self::$rightname, [CREATE, UPDATE, PURGE])) {
          $profile = new Profile();
          echo "<form method='post' action='".$profile->getFormURL()."'>";
       }
 
       $profile = new Profile();
-      $profile->getFromDB($profiles_id);
+      $profile->getFromDB($ID);
 
       $profile->displayRightsChoiceMatrix($this->getAllRights(),
                                                 ['canedit'       => $canedit,
                                                  'default_class' => 'tab_bg_2',
                                                  'title'         => __('General')]);
 
-      if ($canedit
-          && $closeform) {
+      if ($canedit) {
          echo "<div class='center'>";
-         echo Html::hidden('id', ['value' => $profiles_id]);
+         echo Html::hidden('id', ['value' => $ID]);
          echo Html::submit(_sx('button', 'Save'), ['name' => 'update']);
          echo "</div>\n";
          Html::closeForm();