From cf7bfd6cc0af7d4d860b694b5a8166a3e0a069b8 Mon Sep 17 00:00:00 2001 From: MrYoloPotato Date: Mon, 28 Jul 2025 14:55:01 -0600 Subject: [PATCH 1/2] Cast value to float, fixes "must be of type float, string given" when printing pdf with a currency-related value --- inc/config.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/config.class.php b/inc/config.class.php index 8d35393..f9611b0 100644 --- a/inc/config.class.php +++ b/inc/config.class.php @@ -377,7 +377,7 @@ public static function formatNumber($value) $currency = PluginPdfConfig::getInstance(); $fmt = numfmt_create($language, NumberFormatter::CURRENCY); - $val = numfmt_format_currency($fmt, $value, $currency->getField('currency')); + $val = numfmt_format_currency($fmt, (float)$value, $currency->getField('currency')); foreach ($PDF_DEVICES as $option => $value) { if ($currency->fields['currency'] == $option) { $sym = $value[1]; From 515b5b55f955f36f124a037cf702e39f79342cba Mon Sep 17 00:00:00 2001 From: "Romain B." <8530352+Rom1-B@users.noreply.github.com> Date: Tue, 29 Jul 2025 10:42:00 +0200 Subject: [PATCH 2/2] Apply suggestions from code review --- inc/config.class.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/inc/config.class.php b/inc/config.class.php index f9611b0..302973a 100644 --- a/inc/config.class.php +++ b/inc/config.class.php @@ -377,7 +377,7 @@ public static function formatNumber($value) $currency = PluginPdfConfig::getInstance(); $fmt = numfmt_create($language, NumberFormatter::CURRENCY); - $val = numfmt_format_currency($fmt, (float)$value, $currency->getField('currency')); + $val = numfmt_format_currency($fmt, (float) $value, $currency->getField('currency')); foreach ($PDF_DEVICES as $option => $value) { if ($currency->fields['currency'] == $option) { $sym = $value[1];