From 9088dbc1baf89c28a002173df88a9705d4ef0544 Mon Sep 17 00:00:00 2001 From: Marc Dirix Date: Tue, 17 Jun 2025 16:07:39 +0200 Subject: [PATCH 1/6] fix sign bug in humidity --- plugwise_usb/messages/responses.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugwise_usb/messages/responses.py b/plugwise_usb/messages/responses.py index 10104a986..142d3509c 100644 --- a/plugwise_usb/messages/responses.py +++ b/plugwise_usb/messages/responses.py @@ -930,7 +930,7 @@ class SenseReportResponse(PlugwiseResponse): def __init__(self) -> None: """Initialize SenseReportResponse message object.""" super().__init__(SENSE_REPORT_ID) - self.humidity = Int(0, length=4) + self.humidity = Int(0, 4, False) self.temperature = Int(0, length=4) self._params += [self.humidity, self.temperature] From ca9515a16a555c62617ac9e0bd61716236ea06e3 Mon Sep 17 00:00:00 2001 From: Marc Dirix Date: Tue, 17 Jun 2025 16:30:15 +0200 Subject: [PATCH 2/6] fix nitpick --- plugwise_usb/messages/responses.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/plugwise_usb/messages/responses.py b/plugwise_usb/messages/responses.py index 142d3509c..fa00bf48a 100644 --- a/plugwise_usb/messages/responses.py +++ b/plugwise_usb/messages/responses.py @@ -930,7 +930,7 @@ class SenseReportResponse(PlugwiseResponse): def __init__(self) -> None: """Initialize SenseReportResponse message object.""" super().__init__(SENSE_REPORT_ID) - self.humidity = Int(0, 4, False) + self.humidity = Int(0, length=4, negative=False) self.temperature = Int(0, length=4) self._params += [self.humidity, self.temperature] From 9dc194f261cbde18eef3242954eb7dcbd02f421e Mon Sep 17 00:00:00 2001 From: Marc Dirix Date: Tue, 17 Jun 2025 20:07:35 +0200 Subject: [PATCH 3/6] update changelog --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index a43a5f0b9..04b2f9b0a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,10 @@ # Changelog +## ongoing + +- PR [#261] (https://github.com/plugwise/python-plugwise-usb/pull/261L) + - Sense: BugFix parsing of humidity value should be unsigned int + ## v0.44.3 - 2025-06-12 - PR [#260](https://github.com/plugwise/python-plugwise-usb/pull/260) From b78c0a4dd81729b7f6039a2558d363b1e1cea753 Mon Sep 17 00:00:00 2001 From: Marc Dirix Date: Tue, 17 Jun 2025 20:17:33 +0200 Subject: [PATCH 4/6] fix changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 04b2f9b0a..288815f34 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,7 +2,7 @@ ## ongoing -- PR [#261] (https://github.com/plugwise/python-plugwise-usb/pull/261L) +- PR [#261] (https://github.com/plugwise/python-plugwise-usb/pull/261) - Sense: BugFix parsing of humidity value should be unsigned int ## v0.44.3 - 2025-06-12 From 564b08bd992f69b6e261a4561f074d24aa0a9305 Mon Sep 17 00:00:00 2001 From: Bouwe Westerdijk Date: Wed, 18 Jun 2025 08:22:45 +0200 Subject: [PATCH 5/6] Correct/improve CHANGELOG --- CHANGELOG.md | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 288815f34..7e72590cd 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,13 +2,11 @@ ## ongoing -- PR [#261] (https://github.com/plugwise/python-plugwise-usb/pull/261) - - Sense: BugFix parsing of humidity value should be unsigned int +- PR [#261](https://github.com/plugwise/python-plugwise-usb/pull/261): Sense: bugFix parsing of humidity value should be unsigned int ## v0.44.3 - 2025-06-12 -- PR [#260](https://github.com/plugwise/python-plugwise-usb/pull/260) - - Expose enable-auto-joining via CirclePlus interface +- PR [#260](https://github.com/plugwise/python-plugwise-usb/pull/260): Expose enable-auto-joining via CirclePlus interface ## v0.44.2 - 2025-06-11 @@ -16,12 +14,11 @@ ## v0.44.1 - 2025-06-10 -- PR [#258](https://github.com/plugwise/python-plugwise-usb/pull/258) - - Sense: make sure NodeFeature.BATTERY is called and configuration parameters are propagated properly +- PR [#258](https://github.com/plugwise/python-plugwise-usb/pull/258): Sense: make sure NodeFeature.BATTERY is called and configuration parameters are propagated properly ## v0.44.0 - 2025-06-10 -- PR [#256](https://github.com/plugwise/python-plugwise-usb/pull/256) Implement PlugWise Sense product +- PR [#256](https://github.com/plugwise/python-plugwise-usb/pull/256): Implement PlugWise Sense product ## v0.43.0(.2) From f836c4a187845550f302da7a97d559e444598b13 Mon Sep 17 00:00:00 2001 From: Bouwe Westerdijk Date: Wed, 18 Jun 2025 09:05:12 +0200 Subject: [PATCH 6/6] Implement CHANGELOG improvements --- CHANGELOG.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e72590cd..2e198d477 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,8 @@ # Changelog -## ongoing +## Ongoing -- PR [#261](https://github.com/plugwise/python-plugwise-usb/pull/261): Sense: bugFix parsing of humidity value should be unsigned int +- PR [#261](https://github.com/plugwise/python-plugwise-usb/pull/261): Sense: bugfix parsing of humidity value as an unsigned int ## v0.44.3 - 2025-06-12 @@ -18,7 +18,7 @@ ## v0.44.0 - 2025-06-10 -- PR [#256](https://github.com/plugwise/python-plugwise-usb/pull/256): Implement PlugWise Sense product +- PR [#256](https://github.com/plugwise/python-plugwise-usb/pull/256): Implement Plugwise Sense product ## v0.43.0(.2)