Skip to content

Commit 6611145

Browse files
committed
make compile options public for v8pp CMake target
Set alos explicit `-fexceptions` flag for `v8pp` target. See issue #176
1 parent 62d9fb8 commit 6611145

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

v8pp/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ if(MSVC)
5555
# set warning level 3 for system headers
5656
list(APPEND V8PP_COMPILE_OPTIONS /experimental:external /external:anglebrackets /external:W3)
5757
else()
58-
set(V8PP_COMPILE_OPTIONS -fno-rtti -Wall -Wextra -Wpedantic)
58+
set(V8PP_COMPILE_OPTIONS -fno-rtti -fexceptions -Wall -Wextra -Wpedantic)
5959
endif()
6060

6161
if(V8PP_HEADER_ONLY)
@@ -70,7 +70,7 @@ if(V8PP_HEADER_ONLY)
7070
else()
7171
add_library(v8pp ${V8PP_HEADERS} ${V8PP_SOURCES})
7272
target_compile_definitions(v8pp PUBLIC ${V8PP_DEFINES})
73-
target_compile_options(v8pp PRIVATE ${V8PP_COMPILE_OPTIONS})
73+
target_compile_options(v8pp PUBLIC ${V8PP_COMPILE_OPTIONS})
7474
target_include_directories(v8pp PUBLIC
7575
$<BUILD_INTERFACE:${PROJECT_SOURCE_DIR}>
7676
$<BUILD_INTERFACE:${PROJECT_BINARY_DIR}>

0 commit comments

Comments
 (0)