Skip to content

Commit c27f363

Browse files
committed
Improve comment
1 parent 02855f8 commit c27f363

File tree

8 files changed

+642
-644
lines changed

8 files changed

+642
-644
lines changed

shiny/html_dependencies.py

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -20,11 +20,16 @@ def jquery_deps() -> HTMLDependency:
2020
)
2121

2222

23-
# N.B. py-shiny has requirejs as a 'core' dependency since it's currently a pretty
24-
# fundamental dependency for any Jupyter widget project (i.e., ipyshiny) and we need a
25-
# custom setup for it to work decently with HTMLDependency() model (i.e., loading JS via
26-
# <script> tags). At the moment, we're just setting window.define.amd=false after loading
27-
# requirejs so that the typical UMD pattern won't result in an anonymous define() error.
23+
# Shiny doesn't (currently) use requirejs directly, but it does include it because a
24+
# custom requirejs setup is need to get HTMLDependency()s (i.e., loading JS via <script>
25+
# tags) to be usable. At the moment, we're just setting `window.define.amd=false` after
26+
# loading requirejs so that the typical UMD pattern won't result in an anonymous
27+
# define() error.
28+
# https://requirejs.org/docs/errors.html#mismatch
29+
# https://github.com/umdjs/umd
30+
#
31+
# Someday, we may want to the same/similar thing in R, but this definitely going to be
32+
# more of an issue for Python since many Jupyter extensions use requirejs.
2833
def require_deps() -> HTMLDependency:
2934
return HTMLDependency(
3035
name="requirejs",

shiny/www/shared/bootstrap/bootstrap.bundle.min.js

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

shiny/www/shared/bootstrap/bootstrap.bundle.min.js.map

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

shiny/www/shared/bootstrap/bootstrap.min.css

Lines changed: 3 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)