Skip to content

Commit 799900d

Browse files
committed
After parsing version also strip out any non digits
1 parent 332ce87 commit 799900d

File tree

1 file changed

+6
-2
lines changed

1 file changed

+6
-2
lines changed

ipyshiny/_dependencies.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ def libembed_dependency() -> List[HTMLDependency]:
4747
# stuff we need to render widgets outside of the notebook.
4848
HTMLDependency(
4949
name="ipywidget-libembed-amd",
50-
version=packaging.version.parse(__html_manager_version__),
50+
version=as_version(__html_manager_version__),
5151
source={"package": "ipyshiny", "subdir": "static"},
5252
script={"src": "libembed-amd.js"},
5353
),
@@ -98,7 +98,7 @@ def require_dependency(w: Widget, session: Session) -> Optional[HTMLDependency]:
9898
)
9999
return None
100100

101-
version = packaging.version.parse(getattr(w, "_model_module_version", "1.0"))
101+
version = as_version(getattr(w, "_model_module_version", "1.0"))
102102
source = {"package": None, "subdir": module_dir}
103103

104104
dep = HTMLDependency(module_name, version, source=source)
@@ -159,3 +159,7 @@ def jupyter_extension_destination(w: Widget) -> str:
159159

160160
def widget_pkg(w: object) -> str:
161161
return w.__module__.split(".")[0]
162+
163+
164+
def as_version(v: str) -> str:
165+
return re.sub("\\D*", "", str(packaging.version.parse(v)))

0 commit comments

Comments
 (0)